-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme settings max input vars #3327
base: master
Are you sure you want to change the base?
Conversation
It's a dirty way but I don't see any solution to keep compatibility with form extended from the class form. |
on this |
First of all test some options with big deep multi levels arrays. I tried some addable popup in adabalbe popup with switch and again adable popup and is fine. |
when you say test, |
ah I see, form data is 1 now , ok , checking everything |
I think more of us should test this , I do have some large options and multies but someone might have a combo that can cause some issues. Il open a issue calling for more devs |
I mean if all options are saved. Decrease max_input_vars in php.ini and in theme settings add some options types with big deep arrays for example, such as addable popup in adable popup |
looks ok on my end ,
and now it should be
@ViorelEremia , when do you think this will be out in stable ? |
I thought this week but I think it's too late or maybe the prerelease on Friday and update Wednesday. |
checked resets also , looks ok , I would still love to see other test as well since this is a major change |
@ViorelEremia Don't release this jet please, I had to revert back the addable popup returns null , I think there is issue with commas and or quotes
not sure if that is causing the null to be returned from the pupup , so with this current change same popup with 2 elements returns this and it should be this |
@danyj now should work try my last commit |
will do |
@ViorelEremia Still not ok , now all my typography options are null , |
and the thing is that everything is present in form data
on reset it works , once you save, data is sent, but output is null |
this is the working typo print
|
in your string, the last character should be |
it was missing I think, tried to pull it out of long string |
No description provided.