Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'New Tree' Refactors #7

Merged
merged 28 commits into from
Jan 25, 2023
Merged

'New Tree' Refactors #7

merged 28 commits into from
Jan 25, 2023

Commits on Oct 5, 2022

  1. Simplify: fix scaling of maximum area deviation setting 

    meshfix_maximum_extrusion_area_deviation is already in millimeters.
using get<coord_t> divides the value by 1000, instead it should be
get<size_t> or get<int>.
    @Piezoid
    Piezoid committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    6985593 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. Merge pull request #1738 from Piezoid/area_deviation_scaling 

    Simplify: fix scaling of maximum area deviation setting
    @jellespijker
    jellespijker authored Nov 15, 2022
    Configuration menu
    Copy the full SHA
    1adf212 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. Revert "Merge pull request #1738 from Piezoid/area_deviation_scaling" 

    This reverts commit 1adf212, reversing
changes made to 1363b81.
    @rburema
    rburema committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    70b4fbf View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. Merge branch '5.2' into xmas_alpha

    @rburema
    rburema committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    381c257 View commit details
    Browse the repository at this point in the history

  2. Revert "Merge remote-tracking branch 'upstream/main' into tree_suppor… 

    …t_2"

This reverts commit e535e04, reversing
changes made to 034fe14.
    @rburema
    rburema committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    fa11a4b View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. New Tree Support: Quick refactors (except the big class). 

    part of CURA-9879
    @rburema
    rburema committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    a275e9d View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. Sync workflows from main 

    Contributes to CURA-9879
    @jellespijker
    jellespijker committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    ccd74e0 View commit details
    Browse the repository at this point in the history

  2. Use 5.3.0-alpha dependencies 

    Revert before merging to main

Contributes to CURA-9879
    @jellespijker
    jellespijker committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    296d38d View commit details
    Browse the repository at this point in the history

  3. Use latest Arcus 

    Revert before merging to main

Contributes to CURA-9879
    @jellespijker
    jellespijker committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    958bb86 View commit details
    Browse the repository at this point in the history

  4. Use PUBLIC targets for deps in _CuraEngine 

    Contributes to CURA-9879
    @jellespijker
    jellespijker committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    80e50f2 View commit details
    Browse the repository at this point in the history

  5. Use range-v3 instead of std 

    Mac is being Mac again, also the
range-v3 library is used consistently
throughout the rest of the code

Contributes to CURA-9879
    @jellespijker
    jellespijker committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    64e626d View commit details
    Browse the repository at this point in the history

  6. New Tree Support: Refactors part II. 

    Put code in our code style -- including moving comments around, for better readability so definitely not all that is said there is mine ;-)

part of CURA-9879
    @rburema
    rburema committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    2772aa8 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. New Tree Support: Refactors part III. 

    Put code in our code style -- including moving comments around, for better readability so definitely not all that is said there is mine ;-) -- Includes workaround for Mac compiler bug stumbled into in last commit.

part of CURA-9879
    @rburema
    rburema committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    9e1eb70 View commit details
    Browse the repository at this point in the history

  2. Switch back to the original 'pass-by-copy' design. 

    Pass sby reference was erronously introduced by refactoring.

part of CURA-9879
    @rburema
    rburema committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    b734714 View commit details
    Browse the repository at this point in the history

  3. Fix xy_distance overriding overhangs when the overhang angle is small… 

    …ish.

Manually cherry picked for CURA-9879 (git gave a bit of a mess when git cherry-pick was run...)
    @ThomasRahm @rburema
    ThomasRahm authored and rburema committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    8b9c8ac View commit details
    Browse the repository at this point in the history

  4. Small refactor: Break some more comments up into lines. 

    part of CURA-9879
    @rburema
    rburema committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    cf52880 View commit details
    Browse the repository at this point in the history

  5. Small refactors (mostly re-lined comments). 

    part of CURA-9879
    @rburema
    rburema committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    2a25383 View commit details
    Browse the repository at this point in the history

  6. Forgot to rename this instance of mesh for the apple-clang workaround. 

    part of CURA-9879
    @rburema
    rburema committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    ace3dba View commit details
    Browse the repository at this point in the history

  7. Refactor: Use 'using' to abreviate often used types. 

    part of CURA-9879
    @rburema
    rburema committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    92e39af View commit details
    Browse the repository at this point in the history

  8. Minimize use of (implict) sqrt operations. 

    Will not do that much, but standard in the rest of the code.

part of CURA-9879
    @rburema
    rburema committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    8ce602f View commit details
    Browse the repository at this point in the history

  9. Replaced some of the more common magic numbers with constexprs. 

    part of CURA-9879
    @rburema
    rburema committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    7427d77 View commit details
    Browse the repository at this point in the history

  10. Resolve temporary comments made during review. 

    part of CURA-9879
    @rburema
    rburema committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    885fe03 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. 'Workaround' for crash with tree-branch-pref set to 'flat surfaces'. 

    Added a note as well. I have no idea why the (in context) equivalent (even when the static_cast<size_t> is replaced by a simple cast to int) statement, using iota, doesn't work, but this does. It may just expose another bug, but best not to take the risk right now.

part of CURA-9879
    @rburema
    rburema committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    a0dd35d View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2022

  1. Undo small part of refactor that was causing issues. 

    It (moving the area-calculation to outside of the loop) _shoulnd't_ have caused issues (indicating that there's probably some deadlock possibility in the code as-is), but it _did_, so undo this part (for now).

part of CURA-9879
    @rburema
    rburema committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    3c41803 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. Fix potential edge case: All but one of empty list.

    @rburema
    rburema committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    99ca0f9 View commit details
    Browse the repository at this point in the history

  2. take disallowed areas into account when printing tree support

    @BagelOrb @rburema
    BagelOrb authored and rburema committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    a0d1e3a View commit details
    Browse the repository at this point in the history

  3. feat: settings.get<Polygons>

    @BagelOrb @rburema
    BagelOrb authored and rburema committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    d51bfc0 View commit details
    Browse the repository at this point in the history

  4. Moved PropertyAreasX definitions to where they're used.

    @rburema
    rburema committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    369c74d View commit details
    Browse the repository at this point in the history