Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Waker implement doesn't wake thread calling Poller.poll #49

Closed
Thomasdezeeuw opened this issue Aug 5, 2018 · 3 comments
Closed

Waker implement doesn't wake thread calling Poller.poll #49

Thomasdezeeuw opened this issue Aug 5, 2018 · 3 comments
Labels
bug A problem. priority:medium Medium priority issue.

Comments

@Thomasdezeeuw
Copy link
Owner

Currently the cross-thread waker imlementation doesn't actually wake a thread, it just adds another notification. If a thread is idle and calls Poller.poll without a other notifications coming in, no other threads can wake the thread.
@Thomasdezeeuw Thomasdezeeuw added the bug A problem. label Aug 5, 2018
@Thomasdezeeuw Thomasdezeeuw changed the title Waker implement doesn't wake thread call Poller.poll Waker implement doesn't wake thread calling Poller.poll Aug 6, 2018
@Thomasdezeeuw
Copy link
Owner Author

Waiting on the rewrite in the standard library before fixing this.

@Thomasdezeeuw Thomasdezeeuw mentioned this issue Jan 5, 2019
Closed
@Thomasdezeeuw
Copy link
Owner Author

Using Thomasdezeeuw/gaea#45 should fix this.

@Thomasdezeeuw Thomasdezeeuw added the priority:medium Medium priority issue. label Feb 10, 2019
@Thomasdezeeuw
Copy link
Owner Author

Awakener is now available in mio-st v0.2.2, unblocking this. Also see #51.

Thomasdezeeuw added a commit that referenced this issue Feb 23, 2019
@Thomasdezeeuw
Rewrite Waker implementation
520402d 
This updates it to the latest version in the standard library. It also
actually wakes across threads.

Fixes #49.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A problem. priority:medium Medium priority issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Thomasdezeeuw