Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with pyusb 1.0.2 #93

Closed
wants to merge 1 commit into from
Closed

Fix problem with pyusb 1.0.2 #93

wants to merge 1 commit into from

Conversation

robho
Copy link
Contributor

@robho robho commented Nov 15, 2023

USBTimeoutError was introduced in pyusb 1.1.0, so we need to check pyusb version before using it.

USBTimeoutError was introduced in pyusb 1.1.0, so we need to check
pyusb version before using it.
@tuna-f1sh
Copy link
Collaborator

Thanks. I wonder if it would be better to change the psusb requirement https://github.com/Tigge/openant/blob/master/setup.py#L137 . I guess this also fixes it for people just pulling the code and not updating the environment.

I've been meaning to update the the build tool to pyproject PEP-621 in favour of the legacy setup.py so I'll change the version as part of that.

@tuna-f1sh
Copy link
Collaborator

tuna-f1sh commented Nov 16, 2023

I don't see how this change fixes #95 or Tigge/antfs-cli#194 however. The line changed in this PR is just a logger output. The exception is raised in https://github.com/Tigge/openant/blob/master/openant/easy/filter.py#L62

Are you sure you didn't update pyusb in the process of changing this code?

@robho
Copy link
Contributor Author

robho commented Nov 16, 2023

It's ok if you bump pyusb dependency to a higher version. Feel free to close this if you bump the dependency.

(This doesn't fix #94 or #95. This is a separate fix for a problem I encountered in my environment - logging failed / raised an exception because I was using pyusb 1.0.2)

tuna-f1sh added a commit that referenced this pull request Nov 16, 2023
@tuna-f1sh tuna-f1sh closed this Nov 16, 2023
@robho robho deleted the pyusb102 branch November 16, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants