Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use with_metadata instead of argument to pa.schema constructor #1858

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

nguyenv
Copy link
Collaborator

@nguyenv nguyenv commented Nov 2, 2023

  • Pandas 2.0 has deprecated many functions including passing the metadata as an argument to the pa.schema constructor. This has been replaced with a separate call to with_metadata

…uctor

* Pandas 2.0 has deprecated many functions including passing the
  metadata as a constructor to the `pa.schema`. This has been replaced
  with a separate call to `with_metadata`
@nguyenv nguyenv changed the title Set arrow metadata with with_metadata instead of argument to constr… Set arrow metadata with with_metadata instead of argument to constructor Nov 2, 2023
@nguyenv nguyenv changed the title Set arrow metadata with with_metadata instead of argument to constructor Use with_metadata instead of argument to pa.schema constructor Nov 2, 2023
@ihnorton
Copy link
Member

ihnorton commented Nov 2, 2023

Is this backwards-compatible?

@nguyenv
Copy link
Collaborator Author

nguyenv commented Nov 2, 2023

Is this backwards-compatible?

I just tested that this still passes with Pandas 1.5.3.

@johnkerl
Copy link
Contributor

johnkerl commented Nov 2, 2023

[sc-35946]

Copy link

Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THanks

@nguyenv nguyenv merged commit d8da16f into dev Nov 2, 2023
37 checks passed
@nguyenv nguyenv deleted the viviannguyen/pyarrow-to-pandas2-nullable-fix branch November 2, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants