Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility fix: delete_fragments #1966

Merged
merged 1 commit into from
May 15, 2024

Conversation

kounelisagis
Copy link
Member

@kounelisagis kounelisagis commented May 13, 2024

In #1958 the static method delete_fragments replaced the instance method with the same name. This, instead of deprecation warning, caused errors for vector search tests: https://github.com/TileDB-Inc/TileDB-Vector-Search/actions/runs/9060651237/job/24890783433?pr=369

In this PR:

  • Since both methods have the same name and number of required arguments, it's impossible to have two separate methods in Python even after using the @staticmethod decorator. We use just one function, checking the argument type.
    Both tiledb.Array.delete_fragments(path, 2, 2) and
>>> with tiledb.open(path, 'm') as A:
...     A.delete_fragments(2, 2)

are now valid.

  • A higher level delete_fragments() function is deleted. Should have been removed since 0.21.0.

[sc-47282]

@kounelisagis kounelisagis marked this pull request as ready for review May 13, 2024 21:47
@kounelisagis kounelisagis merged commit 997b328 into dev May 15, 2024
34 checks passed
@kounelisagis kounelisagis deleted the agis/sc-47282/compatibility-fix-delete-fragments branch May 15, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants