Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pin to MSVC toolset version in CI. #1991

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Remove pin to MSVC toolset version in CI. #1991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,11 @@ jobs:
- name: Checkout TileDB-Py `dev`
uses: actions/checkout@v3

# By default Visual Studio chooses the earliest installed toolset version
# for the main build and vcpkg chooses the latest. Force it to use the
# latest (14.39 currently).
- name: Setup MSVC toolset (VS 2022)
uses: TheMrMilchmann/setup-msvc-dev@v3
if: matrix.os == 'windows-latest'
with:
arch: x64
toolset: 14.39

- name: Install Ninja (VS 2022)
uses: seanmiddleditch/gha-setup-ninja@v4
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/daily-test-build-numpy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,11 @@ jobs:
- name: Checkout TileDB-Py `dev`
uses: actions/checkout@v3

# By default Visual Studio chooses the earliest installed toolset version
# for the main build and vcpkg chooses the latest. Force it to use the
# latest (14.39 currently).
- name: Setup MSVC toolset (VS 2022)
uses: TheMrMilchmann/setup-msvc-dev@v3
if: matrix.os == 'windows-latest'
with:
arch: x64
toolset: 14.39

- name: Install Ninja (VS 2022)
uses: seanmiddleditch/gha-setup-ninja@v4
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/daily-test-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,15 +43,11 @@ jobs:
VCPKG_BINARY_SOURCES: 'clear;x-gha,readwrite'

steps:
# By default Visual Studio chooses the earliest installed toolset version
# for the main build and vcpkg chooses the latest. Force it to use the
# latest (14.39 currently).
- name: Setup MSVC toolset (VS 2022)
uses: TheMrMilchmann/setup-msvc-dev@v3
if: matrix.os == 'windows-latest'
with:
arch: x64
toolset: 14.39

- name: Enable vcpkg binary caching
uses: actions/github-script@v6
Expand Down
Loading