Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have from_pandas list offending column when _get_column_infos fails #1997

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Have from_pandas list offending column when _get_column_infos fails #1997

merged 1 commit into from
Jul 1, 2024

Conversation

kounelisagis
Copy link
Member

Adds offending column when from_pandas -> _get_column_infos fails.

e.g. NotImplementedError: boolean inferred dtype not supported becomes NotImplementedError: boolean inferred dtype not supported (column foo).

@kounelisagis kounelisagis marked this pull request as ready for review July 1, 2024 08:54
ihnorton
ihnorton approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kounelisagis kounelisagis merged commit 5f43369 into dev Jul 1, 2024
34 checks passed
@kounelisagis kounelisagis deleted the agis/sc-49973/have-from-pandas-list-offending-column-when-get-column-infos-fails branch July 1, 2024 14:56
@leipzig
Copy link
Member

leipzig commented Jul 1, 2024

good stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihnorton ihnorton ihnorton approved these changes

@leipzig leipzig Awaiting requested review from leipzig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kounelisagis @leipzig @ihnorton