Expose setup.py flag to enable deprecations

[kounelisagis]

In #2023, TILEDB_REMOVE_DEPRECATIONS macro was defined.
It would be good to also have this functionality in setup.py.

Right now, the default behavior is to remove deprecations when build TileDB-Py. In core, the default is to enable them.
Should we keep the logic, or follow the core's?

[dudoslav]

I believe that you also need to call:

parser.add_argument("--enable_deprecations", action="store_true")

Also try this command out, by for example adding

message(FATAL_ERROR "I AM HERE")

into CMake's IF condition checking TILEDB_REMOVE_DEPRECATIONS and if it fails it means that you set the variable correctly

[kounelisagis]

I believe that you also need to call:

parser.add_argument("--enable_deprecations", action="store_true")

Also try this command out, by for example adding

message(FATAL_ERROR "I AM HERE")

into CMake's IF condition checking TILEDB_REMOVE_DEPRECATIONS and if it fails it means that you set the variable correctly

@dudoslav you are right, thanks!

Tested with the following seems to work as expected:

if (TILEDB_REMOVE_DEPRECATIONS)
    message(FATAL_ERROR "DEPRECATIONS REMOVED")
    target_compile_definitions(
        cc
        PRIVATE
        TILEDB_REMOVE_DEPRECATIONS
    )
else()
    message(FATAL_ERROR "DEPRECATIONS NOT REMOVED")
endif()

[dudoslav]

Looks good, thanks @kounelisagis