Eliminate reference cycles to improve Ctx cleanup #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihnorton
force-pushed
the
ihn/fix_247
branch
from
e597cd0
to
d24eda4
Compare
For example, due to reference cycle preventing immediate Array deallocation (see following commit). x-ref: #247
ihnorton
force-pushed
the
ihn/fix_247
branch
from
d24eda4
to
d4b9e83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #247 @bkmartinjr demonstrated thread-count oversubscription caused by delayed Array destruction (thus, Ctx deallocation), due to internal reference cycles. These cycles can eventually be freed by the Python GC, but the GC does not run sufficiently often to prevent the issue.