Added test-case covering property referenced via "static" keyword (#66)

TomasVotruba · Jun 26, 2023 · 45d3c21 · 45d3c21
1 parent 1520e42
commit 45d3c21
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 0 deletions.
diff --git a/tests/Rules/UnusedPublicPropertyRule/Fixture/LocallyUsedStaticPropertyViaStatic.php b/tests/Rules/UnusedPublicPropertyRule/Fixture/LocallyUsedStaticPropertyViaStatic.php
@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace TomasVotruba\UnusedPublic\Tests\Rules\UnusedPublicPropertyRule\Fixture;
+
+class LocallyUsedStaticPropertyViaStatic
+{
+    public static $somePublicStaticProperty;
+
+    private function run()
+    {
+        return static::$somePublicStaticProperty;
+    }
+}
diff --git a/tests/Rules/UnusedPublicPropertyRule/UnusedPublicPropertyRuleTest.php b/tests/Rules/UnusedPublicPropertyRule/UnusedPublicPropertyRuleTest.php
@@ -16,6 +16,7 @@
 use TomasVotruba\UnusedPublic\Rules\UnusedPublicPropertyRule;
 use TomasVotruba\UnusedPublic\Tests\Rules\UnusedPublicPropertyRule\Fixture\IgnoresPrivateApiProperty;
 use TomasVotruba\UnusedPublic\Tests\Rules\UnusedPublicPropertyRule\Fixture\LocallyUsedStaticProperty;
+use TomasVotruba\UnusedPublic\Tests\Rules\UnusedPublicPropertyRule\Fixture\LocallyUsedStaticPropertyViaStatic;
 use TomasVotruba\UnusedPublic\Tests\Rules\UnusedPublicPropertyRule\Fixture\LocalyUsedPublicProperty;
 
 final class UnusedPublicPropertyRuleTest extends RuleTestCase
@@ -51,6 +52,16 @@ public static function provideData(): Iterator
             [[$errorMessage, 7, RuleTips::SOLUTION_MESSAGE]],
         ];
 
+        $errorMessage = sprintf(
+            UnusedPublicPropertyRule::ERROR_MESSAGE,
+            LocallyUsedStaticPropertyViaStatic::class,
+            'somePublicStaticProperty'
+        );
+        yield [
+            [__DIR__ . '/Fixture/LocallyUsedStaticPropertyViaStatic.php'],
+            [[$errorMessage, 7, RuleTips::SOLUTION_MESSAGE]],
+        ];
+
         yield [[
             __DIR__ . '/Fixture/AnotherClassUsingPublicStaticProperty.php',
             __DIR__ . '/Source/SkipExternallyUsedPublicStaticProperty.php',