Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"scenario.as.test.fail.terminate" feature doesn't work #196

Closed
itaiag opened this issue Dec 25, 2013 · 2 comments
Closed

"scenario.as.test.fail.terminate" feature doesn't work #196

itaiag opened this issue Dec 25, 2013 · 2 comments

Comments

@itaiag
Copy link
Contributor

itaiag commented Dec 25, 2013

Even when the "scenario.as.test.fail.terminate" flag is turned on, when executing as a scenario that is marked as a test and one of the building blocks inside fails, the building blocks that follows is still executed even when they were supposed to be skipped.

Steps to reproduce:

  • Make sure that the "scenario.as.test.fail.terminate" property is turned on.
  • Create a new scenario s0.
  • Add a few building blocks that should pass
  • Add a building block that fails.
  • Add a few more building blocks that should pass.
  • Mark the scenario as a test
  • Create a new scenario s1.
  • Add scenario s0 to s1
  • Execute scenario s0.

Result:

  • All the building blocks in scenario s0 are executed.

Expected result

  • Building blocks after the one that fails should not be executed.
@itaiag
Copy link
Contributor Author

itaiag commented Jan 23, 2014

If there is another level in the scenario tree. For example, if scenario s2 includes scenario s1, the behaviour works as expected.

@itaiag itaiag modified the milestones: 6.1.02, 6.1.01 Feb 19, 2015
@itaiag itaiag modified the milestones: 6.1.03, 6.1.02 Nov 15, 2015
@itaiag itaiag modified the milestones: 6.1.04, 6.1.03 Apr 12, 2016
@itaiag itaiag modified the milestones: 6.1.05, 6.1.04 Jun 14, 2016
@itaiag itaiag modified the milestones: 6.1.06, 6.1.05 Oct 18, 2016
@itaiag
Copy link
Contributor Author

itaiag commented Jun 14, 2017

It seems that what causes the problem is the XmlReporter. In the startContainer event it resets the run properties which JSystem uses for keeping the property that marks the scenario as test.

itaiag added a commit that referenced this issue Jun 14, 2017
…sed a bug in the 'marked scenario as test' feature. issue #196
@itaiag itaiag closed this as completed Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant