Pushed Jena version to 5.0.0 and updated Caching library #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afs
reviewed
May 26, 2024
| @@ -72,7 +72,7 @@ public MultiUnion createMultiUnion(Graph[] graphs) { | |||
| * @return the default Graph | |||
| */ | |||
| public Graph createDefaultGraph() { | |||
| return Factory.createDefaultGraph(); | |||
| return GraphFactory.createDefaultGraph(); | |||
There was a problem hiding this comment.
Minor: Should this be a call to `JenaUtil.createDefaultGraph()?
There was a problem hiding this comment.
For some reason JenaUtil.createDefaultGraph() is calling the helper class, causing a stack overflow cycle
This is what there is in JenaUtil.
public static Graph createDefaultGraph() { return helper.createDefaultGraph(); }
Maybe this needs to be changed?
|
That comment was for why I did not use If you are using java 21 or 22, you can download my branch and use it. I am using it for project work and training and so far it seems to work well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I was having trouble using 1.4.3 due to Jena classes deprecated or removed - more specifically org.apache.jena.graph.Factory. In my pull request, i've updated Jena to the latest version and also updated the Caching library to use benmanes (https://github.com/ben-manes/caffeine) which is compatible with the previously used library. I believe that the library used in the main fork is not available anymore.
Thanks,
Jeremy
PS. I couldn't assign anyone as reviewer. I guess Holger or Ashley can do this.