cargo: Bump windows crate range to 0.53-0.56
#213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
changed the title
0.54 crate0.56 crate
|
The I'm not sure why it's not mentioned in the release notes. |
MarijnS95
force-pushed
the
windows-0.54-0.55
branch
2 times, most recently
from
aa99351
to
f414708
Compare
MarijnS95
changed the title
0.56 cratewindows crate range to 0.53-0.56
|
This would be great to get in, I've started depending on it locally. Is there anything an outsider could do to help move this along? |
MarijnS95
force-pushed
the
windows-0.54-0.55
branch
from
f414708
to
4a21252
Compare
MarijnS95
force-pushed
the
windows-0.54-0.55
branch
from
4a21252
to
2e86544
Compare
Because of the refactoring of `CanInto` (to now only support `unsafe` `IntoParam` boilerplate for `Abi` purposes) in favour of regular `From` implementations for type-safe upcasting, the new releases are no longer backwards-compatible with `windows 0.51-0.52`.
Most namespaces are parents which are enabled automatically when enabling their childeren (and the root `Win32` namespace depends on `Win32_Foundation` since newer `windows` releases). Except `Direct3D`, which is not required for `gpu-allocator` but only used in the examples.
MarijnS95
force-pushed
the
windows-0.54-0.55
branch
from
2e86544
to
e52803d
Compare
MarijnS95
changed the title
windows crate range to 0.53-0.56windows crate range to 0.53-0.57
MarijnS95
requested review from
tosti007,
EmilioLaiso,
KYovchevski and
manon-traverse
|
Looks like |
tosti007
approved these changes
Jun 11, 2024
MarijnS95
force-pushed
the
windows-0.54-0.55
branch
from
e52803d
to
9fc33b3
Compare
MarijnS95
changed the title
windows crate range to 0.53-0.57windows crate range to 0.53-0.56
|
Ugh, the merge-commit title failed to update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
windows 0.53all the way up to and including0.57to be used, and remove some unused features from the core crate.