Refactor of gpu_allocator to allow for support for more graphics APIs #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| vb_allocation: Allocation, | ||
| ib_allocation: Allocation, |
There was a problem hiding this comment.
How come the SubAllocation got renamed to Allocation? I think this is API churn that we shouldn't really need, and it's also an incorrect name, since the this data still refers to a sub allocation of either a VkMemory or ID3D12Heap.
There was a problem hiding this comment.
The idea was that not every allocation returned by the allocator is a sub-allocation (allocations taking an entire block). Since this PR will require API changes I think it's not a bad idea to make this change now instead of another time.
manon-traverse
changed the title
manon-traverse
force-pushed
the
multi-api-refactor
branch
from
fdacfde
to
38221d5
Compare
manon-traverse
force-pushed
the
multi-api-refactor
branch
from
38221d5
to
934fb0a
Compare
Jasper-Bekkers
approved these changes
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the main features on the todo list for
gpu-allocatoris D3D12 support. Sincegpu-allocatorwas originally written for vulkan support, we need to make some changes to support multiple graphics APIs. This PR does all the prep work to add D3D12 support.One of the big downsides is that it requires changes to the API. This is mainly due to splitting the graphics API agnostic and graphics API specific code.