Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: move baseUrl to httpClient system options #494

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

osoykan
Copy link
Collaborator

@osoykan osoykan commented Jun 27, 2024

As it is not directly related with TestSytem, and main usage of base URL is scoped inside the httpClient validation dsl.

Copy link

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.95%. Comparing base (fbad811) to head (5919b2a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #494      +/-   ##
==========================================
+ Coverage   83.91%   83.95%   +0.03%     
==========================================
  Files          83       83              
  Lines        2027     2025       -2     
  Branches       96       96              
==========================================
- Hits         1701     1700       -1     
+ Misses        262      261       -1     
  Partials       64       64              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@osoykan osoykan merged commit a2e78e8 into main Jun 27, 2024
3 checks passed
@osoykan osoykan deleted the baseurl branch June 27, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant