Change BatchLogRecordProcessorFactory::Create to static method, Fixed…

… a typo in a comment (open-telemetry#1876)
Troels51 · Dec 21, 2022 · 9dd19a2 · 9dd19a2
1 parent 066c2f3
commit 9dd19a2
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,6 +15,7 @@ Increment the:
 
 ## [Unreleased]
 
+* [METRICS] Change BatchLogRecordProcessorFactory::Create to static method
 * [BUILD] Fix OTELCPP_MAINTAINER_MODE [#1844](https://github.com/open-telemetry/opentelemetry-cpp/pull/1844)
 * [BUILD] Fix compatibility when using clang and libc++, upgrade GTest and
   cmake when using C++20 [#1852](https://github.com/open-telemetry/opentelemetry-cpp/pull/1852)

diff --git a/sdk/include/opentelemetry/sdk/common/global_log_handler.h b/sdk/include/opentelemetry/sdk/common/global_log_handler.h
@@ -134,7 +134,7 @@ class GlobalLogHandler
 OPENTELEMETRY_END_NAMESPACE
 
 /**
- * GlobalLogHandler and TracerProvider/MeterProvider/LoggerProvider are lazy sigletons.
+ * GlobalLogHandler and TracerProvider/MeterProvider/LoggerProvider are lazy singletons.
  * To ensure that GlobalLogHandler is the first one to be initialized (and so last to be
  * destroyed), it is first used inside the constructors of TraceProvider, MeterProvider
  * and LoggerProvider for debug logging. */

diff --git a/sdk/include/opentelemetry/sdk/logs/batch_log_record_processor_factory.h b/sdk/include/opentelemetry/sdk/logs/batch_log_record_processor_factory.h
@@ -27,8 +27,8 @@ class BatchLogRecordProcessorFactory
   /**
    * Create a BatchLogRecordProcessor.
    */
-  std::unique_ptr<LogRecordProcessor> Create(std::unique_ptr<LogRecordExporter> &&exporter,
-                                             const BatchLogRecordProcessorOptions &options);
+  static std::unique_ptr<LogRecordProcessor> Create(std::unique_ptr<LogRecordExporter> &&exporter,
+                                                    const BatchLogRecordProcessorOptions &options);
 };
 
 }  // namespace logs