Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix method declarations to conform with napi default for methods #1510

Merged
merged 3 commits into from
May 21, 2022

Conversation

alexanderfloh
Copy link
Contributor

Fix native method implementation to use the proper default options for methods (see nodejs/node-addon-api#811 for details).

This has the beneficial effect that it allows instrumenting the sqlite3 API for tools like Open Telemetry or other APM tools.

Note: instrumentation was possible before sqlite3 v5 and the switch to NAPI.

@alexanderfloh
Copy link
Contributor Author

@kewde can you please consider this for merging? Thanks!

@daniellockyer
Copy link
Member

@alexanderfloh Would you be able to rebase the PR? 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants