Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speculative fix for #568 #569

Merged
merged 2 commits into from
Jul 1, 2017
Merged

Speculative fix for #568 #569

merged 2 commits into from
Jul 1, 2017

Conversation

johnnyreilly
Copy link
Member

No description provided.

…ly mode

Not useful for when using ts-loader with fork-ts-checker-webpack-plugin.  Can still be set manually with tsconfig.json if desired and so arguably not a breaking change
@johnnyreilly
Copy link
Member Author

@donaldpipowitch I've included the change we discussed about dropping this piece of code:

        // do any necessary config massaging		
        if (loaderOptions.transpileOnly) {		
            configFile.config.compilerOptions.isolatedModules = true;		
        }

This can still be set via tsconfig.json if desired. It just won't be set by default anymore (since it's not useful with fork-ts-checker-webpack-plugin in the mix anyway)

@donaldpipowitch
Copy link
Contributor

Thank you for pinging 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants