Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump typescript to 5.3.2 #2445

Merged
merged 6 commits into from
Nov 25, 2023
Merged

Conversation

li-jia-nan
Copy link
Contributor

@li-jia-nan li-jia-nan commented Nov 20, 2023

Resolves #2445

@li-jia-nan
Copy link
Contributor Author

@Gerrit0 Hi, can you review this PR ? thanks

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Nov 21, 2023

I definitely want a test that checks that typedoc interacts with import attributes correctly - particularly that it doesn't get confused by resolution-mode. Looks like that's the only change in this TS version that matters to typedoc

@li-jia-nan
Copy link
Contributor Author

I definitely want a test that checks that typedoc interacts with import attributes correctly - particularly that it doesn't get confused by resolution-mode. Looks like that's the only change in this TS version that matters to typedoc

I'm sorry, I don't know how to add a test, can you give me some tips?

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Nov 21, 2023

Take a look in the src/test folder - particularly the behavior.c2.test.ts file. Tests in that file use the src/test/converter2/behavior files as input, so you can set up a file which references another file that has both esm and cjs variants that export a different type, and make sure that the converted reflections also respect that. I should have time Thursday or this weekend to build tests if you don't have the time.

@Gerrit0 Gerrit0 merged commit 25f1beb into TypeStrong:master Nov 25, 2023
4 checks passed
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Nov 25, 2023

Thanks!

@li-jia-nan
Copy link
Contributor Author

Thanks!

You're welcome, I'd like to know when is the next release ?

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Nov 25, 2023

Today or tomorrow, have a couple issues I'd like to get in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants