-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump typescript to 5.3.2 #2445
Conversation
@Gerrit0 Hi, can you review this PR ? thanks |
I definitely want a test that checks that typedoc interacts with import attributes correctly - particularly that it doesn't get confused by resolution-mode. Looks like that's the only change in this TS version that matters to typedoc |
I'm sorry, I don't know how to add a test, can you give me some tips? |
Take a look in the src/test folder - particularly the behavior.c2.test.ts file. Tests in that file use the src/test/converter2/behavior files as input, so you can set up a file which references another file that has both esm and cjs variants that export a different type, and make sure that the converted reflections also respect that. I should have time Thursday or this weekend to build tests if you don't have the time. |
Thanks! |
You're welcome, I'd like to know when is the next release ? |
Today or tomorrow, have a couple issues I'd like to get in |
Resolves #2445