Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use first bash from PATH (allows running on macOS) #169

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Use first bash from PATH (allows running on macOS) #169

merged 1 commit into from
Oct 23, 2023

Conversation

stweil
Copy link
Member

@stweil stweil commented Oct 22, 2023

/bin/bash on macOS is too old (3.2.57), but can be replaced by a recent bash version from Homebrew.

@stweil
Use first bash from PATH (allows running on macOS)
b96061d 
/bin/bash on macOS is too old (3.2.57), but can be replaced
by a recent bash version from Homebrew.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
kba
kba approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@kba kba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We also had that problem with OSX in the OCR-D/core unit tests, where s,/bin/bash,/usr/bin/env bash, fixed it. We should do that for all bash scripts.

@stweil stweil merged commit cb5defa into master Oct 23, 2023
2 checks passed
@stweil stweil deleted the bash branch October 23, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kba kba kba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stweil @kba