Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation and setup.py requirements #1006

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

thremilien
Copy link
Contributor

Updating documentation for ubuntu 24.04 and adding requests version in requirements (needed for docker)

@CLAassistant
Copy link

CLAassistant commented Aug 19, 2024

CLA assistant check
All committers have signed the CLA.


Then, Mongo:

.. code-block:: bash

wget -qO - https://www.mongodb.org/static/pgp/server-6.0.asc | sudo apt-key add -
echo "deb [ arch=amd64,arm64 ] https://repo.mongodb.org/apt/ubuntu jammy/mongodb-org/6.0 multiverse" | sudo tee /etc/apt/sources.list.d/mongodb-org-6.0.list
sudo apt install gnupg wget apt-transport-https ca-certificates software-properties-common
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can put these requirements at line 90 instead.


$ pip install INGInious
pip install setuptools
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be necessary. For deployments pip install inginious remains the way to go.
Developers can do pip install .


.. note::
For development purpose you may want to run this command to remove the scripts from python folder :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To install dependencies only

setup.py Outdated
@@ -74,7 +75,8 @@
"saml2": ["python3-saml==1.16.0"],
"uwsgi": ["uwsgi==2.0.24"],
"test": test_requires,
"doc": test_requires + doc_requires
"doc": test_requires + doc_requires,
"dev": install_requires
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"dev": install_requires

@anthonygego
Copy link
Member

Can you sign the CLA ?

@anthonygego anthonygego merged commit fcb729e into UCL-INGI:master Aug 20, 2024
2 of 3 checks passed
thremilien added a commit to thremilien/INGInious that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants