Assorted render_trace fixes and improvements:
#440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## development #440 +/- ##
===============================================
+ Coverage 91.29% 91.31% +0.02%
===============================================
Files 24 24
Lines 6351 6357 +6
===============================================
+ Hits 5798 5805 +7
+ Misses 553 552 -1 ☔ View full report in Codecov by Sentry. |
- Add an `enum_name` utility to convert enum values to their names. Python 3.11 changed the behavior of `IntEnum.__str__` to return the enum value rather than the enum name (https://docs.python.org/3/library/enum.html#enum.IntEnum), so `enum_name` makes it easier to see the names. - Update state machine example to display state names with enum_name. - Fix a bug in `render_trace`'s ruler rendering, where cycle numbers were not truncated appropriately when the cycle number is too long. Add a test. - Display more cycles in the renderer demo. Reduce segment_size in several examples. - introduction-to-hardware: Run for more cycles to make it clearer that it is computing the Fibonacci sequence, and not just counting. Drop `n_in` to zero after the first cycle to clarify that it is only used when `req_in` is high. Display `i` to show some internals of the computation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enum_nameutility to convert enum values to their names. Python 3.11 changed the behavior ofIntEnum.__str__to return the enum value rather than the enum name (https://docs.python.org/3/library/enum.html#enum.IntEnum), soenum_namemakes it easier to see the names.render_trace's ruler rendering, where cycle numbers were not truncated appropriately when the cycle number is too long. Add a test.