Replaced parallelshell (deprecated) with npm-run-all, also removed unn… #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joefitter
force-pushed
the
devtask/31-remove-parallelshell
branch
from
b2b4b0c
to
0a96052
Compare
|
Please rebase this PR we try not to allow merge commits to get into PR's |
|
@joefitter also please try and follow this commit style https://github.com/alphagov/styleguides/blob/master/git.md |
joefitter
force-pushed
the
devtask/31-remove-parallelshell
branch
from
6067aba
to
5bd6614
Compare
joefitter
changed the title
joefitter
changed the title
joefitter
force-pushed
the
devtask/31-remove-parallelshell
branch
2 times, most recently
from
2095b37
to
289dc4b
Compare
|
@joefitter we will can go over this at Monday's ways of working meeting, in the interim: https://robots.thoughtbot.com/5-useful-tips-for-a-better-commit-message Otherwise good job |
|
Brill article - I have always used the -m flag and squashed commit messages. Thanks for this! |
joefitter
force-pushed
the
devtask/31-remove-parallelshell
branch
from
289dc4b
to
41ee428
Compare
…s been deprecated in favour of the latter See issue mysticatea/npm-run-all#10 * Removed parallelshell and added npm-run-all * Added a new watch:app npm script which sets NODE_ENV to development and starts nodemon in current directory * Altered dev npm script to run npm-run-all with `--parallel` flag, this concurrently runs tasks `watch:app`, `watch:scss`, `watch:js` and `watch:translations`
joefitter
force-pushed
the
devtask/31-remove-parallelshell
branch
from
41ee428
to
adf6a2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ec path for node-sass exec #31