Fixes #36 - use phantomjs-gem version 1.9.8.0 to match the version pr… #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…einstalled on travis
|
This should fix #33 |
joefitter
added a commit
that referenced
this pull request
Apr 8, 2016
…einstalled on travis Merge pull request #37 from UKHomeOffice/devtask/36-fix-version-of-phantomjs Fixes #36 - use phantomjs-gem version 1.9.8.0 to match the version pr… fixes #33 - validation errors on first page relating to date fixed 2 typos in comments regarding overriding required validtion merged in master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…einstalled on travis
This is necessary because travis quite often fails to download phantomjs 2.2 from CDN and comes with 1.9.8 preinstalled.
More info here: colszowka/phantomjs-gem#70
and
colszowka/phantomjs-gem#79