Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with not sorting columns for reduced vars #37

Merged
merged 3 commits into from
May 22, 2024

Conversation

katelynqueen98
Copy link
Contributor

Hi Malcolm,

We found a bug in the last step of the sorting process. Previously, the code was resorting rows without resorting the columns, leading to problems with indices not matching. This fixes that.

Thanks,
K

@malcolmbarrett
Copy link
Collaborator

LGTM. Do you plan to do anything else soon or should I ship this off to CRAN?

@katelynqueen98
Copy link
Contributor Author

katelynqueen98 commented May 20, 2024 via email

@malcolmbarrett malcolmbarrett merged commit 8bc6314 into USCbiostats:master May 22, 2024
6 of 7 checks passed
@malcolmbarrett
Copy link
Collaborator

Thanks, the fix is on its way to CRAN!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants