Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brim overhaul: New features and bug fixes #11678

Merged
merged 16 commits into from
Oct 30, 2022
Merged

Brim overhaul: New features and bug fixes #11678

merged 16 commits into from
Oct 30, 2022

Commits on Mar 16, 2022

  1. fix disallowed areas taking brim_gap into account

    @BagelOrb
    BagelOrb committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    f7049ca View commit details
    Browse the repository at this point in the history

  2. fix inclusion of brim_gap in TestBuildVolume

    @BagelOrb
    BagelOrb committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    a35a38c View commit details
    Browse the repository at this point in the history

  3. make skirt_brim_extruder_nr an optional_extruder to allow for the bri… 

    …m_per_material feature
    @BagelOrb
    BagelOrb committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    2698cd7 View commit details
    Browse the repository at this point in the history

  4. fixes for optional skirt_brim_extruder_nr

    @BagelOrb
    BagelOrb committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    33e3a45 View commit details
    Browse the repository at this point in the history

  5. reduce clearance needed between prime tower and models 

    With the new implementation we don't need that much clearance.
    @BagelOrb
    BagelOrb committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    0339e4f View commit details
    Browse the repository at this point in the history

  6. remove brim max 

    With the new brim algorithms the brim will never be generated outside of the volume.
It's nice to be able to input 9999 if you want the brim to cover the whole build plate...
... for testing purposes ;)
    @BagelOrb
    BagelOrb committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    1bd6cbb View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2022

  1. Fix limit_to_extruder for skirt_brim_extruder

    @BagelOrb
    BagelOrb committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    1f2ca2a View commit details
    Browse the repository at this point in the history

  2. fix: fix wrong placement of prime tower disallowed area 

    The prime tower should no longer be displaced by the brim width
    @BagelOrb
    BagelOrb committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    fb8787f View commit details
    Browse the repository at this point in the history

  3. brim_inside_margin user setting 

    it allows for removing the brim inside holes completely if set to a high value,
or just keep it a small distance away from internal holes
    @BagelOrb
    BagelOrb committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    d9282ea View commit details
    Browse the repository at this point in the history

  4. remove skirt/brim adhesion size constraint 

    it is handled by CuraEngine now.
    @BagelOrb
    BagelOrb committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    4d146e8 View commit details
    Browse the repository at this point in the history

  5. remove special case for prime tower brim disallowed area 

    It's now handled in CuraEngine
    @BagelOrb
    BagelOrb committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    6da67e3 View commit details
    Browse the repository at this point in the history

  6. allow any material to set the brim extruder to not overridden

    @BagelOrb
    BagelOrb committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    91a5d15 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2022

  1. reduce testing of bed adhesion size

    @BagelOrb
    BagelOrb committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    fabaf20 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2022

  1. Merge branch 'main' into brim_per_material_optimized_order

    @rburema
    rburema committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    ab51bd6 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2022

  1. Fix unlinked brim settings behaviour. 

    Some brim settings seemed to behave as if they where linked, when in fact for any extruder set to -1 the 'default extruder' was set by some hacky code that supposedly fixes a 'dissallowed area' issue, very likely also related to the skirt/brim settings. Since dissalowed area for skirt/brim will not be a thing anymore, at least in the front-end, due to CURA-9066 (the 'parent' jira ticket that was blocked by this bug); it was sinplest just to remove the hack altogether. (Otherwise we'd have to make an artificial distinction between -1 and None as it relates to 'Not Set/Used' versus 'Not Overridden', only to then force it back to -1 in situations that call for it -- like communicating to the engine.)

CURA-9553
    @rburema
    rburema committed Oct 30, 2022
    Configuration menu
    Copy the full SHA
    24bb1e9 View commit details
    Browse the repository at this point in the history

  2. Engine should know to (not) offset the nozzles w.r.t. disallowed areas. 

    part of CURA-9066
    @rburema
    rburema committed Oct 30, 2022
    Configuration menu
    Copy the full SHA
    45fb71e View commit details
    Browse the repository at this point in the history