Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CURA-7245_fix_bundled_package_sync #7707

Merged
merged 2 commits into from
May 11, 2020
Merged

CURA-7245_fix_bundled_package_sync #7707

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ecd30d
Merge branch 'master' of https://github.com/Ultimaker/Cura
ninovanhooff May 6, 2020
3ac0e7b
Consider all packages when calculating account discrepancies
ninovanhooff May 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/Toolbox/src/CloudSync/CloudPackageChecker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ def _onUserPackagesRequestFinished(self, reply: "QNetworkReply", error: Optional
Logger.log("w", "Received invalid JSON for user subscribed packages from the Web Marketplace")

def _handleCompatibilityData(self, subscribed_packages_payload: List[Dict[str, Any]]) -> None:
user_subscribed_packages = [plugin["package_id"] for plugin in subscribed_packages_payload]
user_installed_packages = self._package_manager.getUserInstalledPackages()
user_subscribed_packages = {plugin["package_id"] for plugin in subscribed_packages_payload}
user_installed_packages = self._package_manager.getAllInstalledPackageIDs()

# We need to re-evaluate the dismissed packages
# (i.e. some package might got updated to the correct SDK version in the meantime,
Expand Down