Skip to content

Commit

Permalink
Apply review suggestions
Browse files Browse the repository at this point in the history
Contribute to NP-327
  • Loading branch information
jellespijker committed Aug 15, 2024
1 parent e3d815c commit 9b4a913
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 4 deletions.
4 changes: 2 additions & 2 deletions include/Application.h
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,14 @@ class Application : NoCopy
* can assume that it is safe to access this without checking whether it is
* initialised.
*/
std::shared_ptr<Communication> communication_{ nullptr };
std::shared_ptr<Communication> communication_;

/*
* \brief The slice that is currently ongoing.
*
* If no slice has started yet, this will be a nullptr.
*/
std::shared_ptr<Slice> current_slice_{ nullptr };
std::shared_ptr<Slice> current_slice_;

/*!
* \brief ThreadPool with lifetime tied to Application
Expand Down
1 change: 1 addition & 0 deletions include/communication/EmscriptenCommunication.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ namespace cura
*/
class EmscriptenCommunication : public CommandLine
{
private:
std::string progress_handler_; ///< Handler for progress messages.
std::string slice_info_handler_; ///< Handler for slice information messages.

Expand Down
2 changes: 1 addition & 1 deletion src/communication/EmscriptenCommunication.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ std::string EmscriptenCommunication::createSliceInfoMessage()
}
doc.AddMember("material_estimates", material_estimates_json, allocator);

// Set CureEngine information
// Set CuraEngine information
rapidjson::Value slicer_info_json(rapidjson::kObjectType);
rapidjson::Value slicer_version(CURA_ENGINE_VERSION, allocator);
doc.AddMember("slicer_info", slicer_info_json, allocator);
Expand Down
2 changes: 1 addition & 1 deletion stress_benchmark/stress_benchmark.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ void createAndWriteJson(const std::filesystem::path& out_file, double stress_lev
{
rapidjson::Document doc;
doc.SetArray();
rapidjson::Document::AllocatorType& allocator = doc.GetAllocator();
rapidjson::Document::AllocatorType& allocator = doc.GetAllocator();
auto no_test_cases_obj = createRapidJSONObject(allocator, "Number of test cases", no_test_cases, "-", "");
doc.PushBack(no_test_cases_obj, allocator);

Expand Down

0 comments on commit 9b4a913

Please sign in to comment.