Cura 10732 testing 1 2 3 #1903

jellespijker · 2023-07-12T17:08:25Z

Testing stuff Do not merge

part of CURA-10732

Contributes to CURA-10732

CURA-10732

Needed to get the compile database and the 3th party headers CURA-10732

github-actions

⚠️ clang-tidy found issue(s) with the introduced code (1/2)

github-actions · 2023-07-12T17:50:32Z

src/infill.cpp

+Polygons Infill::generateWallToolPaths(std::vector<VariableWidthLines>& toolpaths,
+                                       Polygons& outer_contour,
+                                       const size_t wall_line_count,
+                                       const coord_t line_width,


⚠️ bugprone-easily-swappable-parameters ⚠️
2 adjacent parameters of generateWallToolPaths of similar type (const cura::coord_t) are easily swapped by mistake

github-actions · 2023-07-12T17:50:32Z

src/infill.cpp

+                                       const coord_t infill_overlap,
+                                       const Settings& settings,
+                                       int layer_idx,
+                                       SectionType section_type)
 {
    outer_contour = outer_contour.offset(infill_overlap);


⚠️ bugprone-narrowing-conversions ⚠️
narrowing conversion from cura::coord_t (aka long long) to signed type int is implementation-defined

github-actions · 2023-07-12T17:50:32Z

src/infill.cpp

-                small_infill_part.offset(-infill_line_width / 2).offset(infill_line_width / 2).area() < infill_line_width * infill_line_width * 10
-                && ! inner_contour.intersection(small_infill_part.offset(infill_line_width / 4)).empty()
-            )
+            if (small_infill_part.offset(-infill_line_width / 2).offset(infill_line_width / 2).area() < infill_line_width * infill_line_width * 10 && ! inner_contour.intersection(small_infill_part.offset(infill_line_width / 4)).empty())


⚠️ bugprone-narrowing-conversions ⚠️
narrowing conversion from long long to signed type int is implementation-defined

github-actions · 2023-07-12T17:50:32Z

src/infill.cpp

-                small_infill_part.offset(-infill_line_width / 2).offset(infill_line_width / 2).area() < infill_line_width * infill_line_width * 10
-                && ! inner_contour.intersection(small_infill_part.offset(infill_line_width / 4)).empty()
-            )
+            if (small_infill_part.offset(-infill_line_width / 2).offset(infill_line_width / 2).area() < infill_line_width * infill_line_width * 10 && ! inner_contour.intersection(small_infill_part.offset(infill_line_width / 4)).empty())


⚠️ bugprone-narrowing-conversions ⚠️
narrowing conversion from long long to signed type int is implementation-defined

github-actions · 2023-07-12T17:50:32Z

src/infill.cpp

-                small_infill_part.offset(-infill_line_width / 2).offset(infill_line_width / 2).area() < infill_line_width * infill_line_width * 10
-                && ! inner_contour.intersection(small_infill_part.offset(infill_line_width / 4)).empty()
-            )
+            if (small_infill_part.offset(-infill_line_width / 2).offset(infill_line_width / 2).area() < infill_line_width * infill_line_width * 10 && ! inner_contour.intersection(small_infill_part.offset(infill_line_width / 4)).empty())


⚠️ bugprone-narrowing-conversions ⚠️
narrowing conversion from long long to double

github-actions · 2023-07-12T17:50:33Z

src/infill.cpp

-                small_infill_part.offset(-infill_line_width / 2).offset(infill_line_width / 2).area() < infill_line_width * infill_line_width * 10
-                && ! inner_contour.intersection(small_infill_part.offset(infill_line_width / 4)).empty()
-            )
+            if (small_infill_part.offset(-infill_line_width / 2).offset(infill_line_width / 2).area() < infill_line_width * infill_line_width * 10 && ! inner_contour.intersection(small_infill_part.offset(infill_line_width / 4)).empty())


⚠️ cppcoreguidelines-avoid-magic-numbers ⚠️
10 is a magic number; consider replacing it with a named constant

github-actions · 2023-07-12T17:50:33Z

src/infill.cpp

-                small_infill_part.offset(-infill_line_width / 2).offset(infill_line_width / 2).area() < infill_line_width * infill_line_width * 10
-                && ! inner_contour.intersection(small_infill_part.offset(infill_line_width / 4)).empty()
-            )
+            if (small_infill_part.offset(-infill_line_width / 2).offset(infill_line_width / 2).area() < infill_line_width * infill_line_width * 10 && ! inner_contour.intersection(small_infill_part.offset(infill_line_width / 4)).empty())


⚠️ bugprone-narrowing-conversions ⚠️
narrowing conversion from long long to signed type int is implementation-defined

github-actions · 2023-07-12T17:50:33Z

src/infill.cpp

    generateLinearBasedInfill(result, line_distance, rotation_matrix, lines_processor, connected_zigzags, shift);
 }


 void Infill::generateZigZagInfill(Polygons& result, const coord_t line_distance, const double& infill_rotation)
 {
-    const coord_t shift = getShiftOffsetFromInfillOriginAndRotation(infill_rotation);
+    const coord_t shift = getShiftOffsetFromInfillOriginAndRotation(infill_rotation); // and here

    PointMatrix rotation_matrix(infill_rotation);
    ZigzagConnectorProcessor zigzag_processor(rotation_matrix, result, use_endpieces, connected_zigzags, skip_some_zags, zag_skip_count);


⚠️ bugprone-narrowing-conversions ⚠️
narrowing conversion from size_t (aka unsigned long) to signed type int is implementation-defined

github-actions · 2023-07-12T17:50:33Z

src/infill.cpp

@@ -596,10 +609,10 @@ void Infill::generateLinearBasedInfill(Polygons& result, const int line_distance
        shift = shift % line_distance;
    }

-    AABB boundary(outline);
+    AABB boundary__(outline);


⚠️ bugprone-reserved-identifier ⚠️
declaration uses identifier boundary__, which is a reserved identifier

github-actions · 2023-07-12T17:50:33Z

src/infill.cpp

@@ -596,10 +609,10 @@ void Infill::generateLinearBasedInfill(Polygons& result, const int line_distance
        shift = shift % line_distance;
    }

-    AABB boundary(outline);
+    AABB boundary__(outline);


⚠️ readability-identifier-naming ⚠️
invalid case style for variable boundary__

github-actions

⚠️ clang-tidy found issue(s) with the introduced code (2/2)

github-actions · 2023-07-12T17:50:46Z

src/infill.cpp


-    int scanline_min_idx = computeScanSegmentIdx(boundary.min.X - shift, line_distance);
-    int line_count = computeScanSegmentIdx(boundary.max.X - shift, line_distance) + 1 - scanline_min_idx;
+    int scanline_min_idx = computeScanSegmentIdx(boundary__.min.X - shift, line_distance);


⚠️ bugprone-narrowing-conversions ⚠️
narrowing conversion from long long to signed type int is implementation-defined

github-actions · 2023-07-12T17:50:46Z

src/infill.cpp

-    int scanline_min_idx = computeScanSegmentIdx(boundary.min.X - shift, line_distance);
-    int line_count = computeScanSegmentIdx(boundary.max.X - shift, line_distance) + 1 - scanline_min_idx;
+    int scanline_min_idx = computeScanSegmentIdx(boundary__.min.X - shift, line_distance);
+    int line_count = computeScanSegmentIdx(boundary__.max.X - shift, line_distance) + 1 - scanline_min_idx;


⚠️ bugprone-narrowing-conversions ⚠️
narrowing conversion from long long to signed type int is implementation-defined

github-actions · 2023-07-12T17:50:46Z

src/infill.cpp

-    const int min_scanline_index = computeScanSegmentIdx(boundary.min.X - shift, line_distance) + 1;
-    const int max_scanline_index = computeScanSegmentIdx(boundary.max.X - shift, line_distance) + 1;
+
+    const int min_scanline_index = computeScanSegmentIdx(boundary__.min.X - shift, line_distance) + 2;


⚠️ bugprone-narrowing-conversions ⚠️
narrowing conversion from long long to signed type int is implementation-defined

github-actions · 2023-07-12T17:50:46Z

src/infill.cpp

+
+    const int min_scanline_index = computeScanSegmentIdx(boundary__.min.X - shift, line_distance) + 2;
+
+    const int max_scanline_index = computeScanSegmentIdx(boundary__.max.X - shift, line_distance) + 1;


⚠️ bugprone-narrowing-conversions ⚠️
narrowing conversion from long long to signed type int is implementation-defined

github-actions · 2023-07-12T17:52:19Z

Unit Test Results

26 tests ±0 24 ✔️ - 2 12s ⏱️ -1s
  1 suites ±0   0 💤 ±0
  1 files ±0   2 ❌ +2

For more details on these failures, see this check.

Results for commit 0dd4893. ± Comparison against base commit ef46801.

♻️ This comment has been updated with latest results.

This version is needed for the printer-linter workflow Contributes to CURA-10732

rburema and others added 6 commits July 12, 2023 15:36

Add clang-format and clang-linting to push/PR actions.

d7016a4

part of CURA-10732

Testing 1, 2, 3

0e63fd7

Contributes to CURA-10732

Applied clang-format.

9c4a707

dummy changes

db83997

CURA-10732

Applied clang-format.

813d3ce

Build CuraEngine

cb46e4e

Needed to get the compile database and the 3th party headers CURA-10732

github-actions bot requested changes Jul 12, 2023

View reviewed changes

don't ping clang tidy GH action version

0dd4893

This version is needed for the printer-linter workflow Contributes to CURA-10732

jellespijker closed this Jul 19, 2023

jellespijker deleted the CURA-10732_testing_1_2_3 branch July 19, 2023 16:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cura 10732 testing 1 2 3 #1903

Cura 10732 testing 1 2 3 #1903

jellespijker commented Jul 12, 2023

github-actions bot left a comment

github-actions bot Jul 12, 2023

github-actions bot Jul 12, 2023

github-actions bot Jul 12, 2023

github-actions bot Jul 12, 2023

github-actions bot Jul 12, 2023

github-actions bot Jul 12, 2023

github-actions bot Jul 12, 2023

github-actions bot Jul 12, 2023

github-actions bot Jul 12, 2023

github-actions bot Jul 12, 2023

github-actions bot left a comment

github-actions bot Jul 12, 2023

github-actions bot Jul 12, 2023

github-actions bot Jul 12, 2023

github-actions bot Jul 12, 2023

github-actions bot commented Jul 12, 2023 •

edited

Loading


		const int min_scanline_index = computeScanSegmentIdx(boundary__.min.X - shift, line_distance) + 2;

		const int max_scanline_index = computeScanSegmentIdx(boundary__.max.X - shift, line_distance) + 1;

Cura 10732 testing 1 2 3 #1903

Cura 10732 testing 1 2 3 #1903

Conversation

jellespijker commented Jul 12, 2023

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Jul 12, 2023

Choose a reason for hiding this comment

github-actions bot Jul 12, 2023

Choose a reason for hiding this comment

github-actions bot Jul 12, 2023

Choose a reason for hiding this comment

github-actions bot Jul 12, 2023

Choose a reason for hiding this comment

github-actions bot Jul 12, 2023

Choose a reason for hiding this comment

github-actions bot Jul 12, 2023

Choose a reason for hiding this comment

github-actions bot Jul 12, 2023

Choose a reason for hiding this comment

github-actions bot Jul 12, 2023

Choose a reason for hiding this comment

github-actions bot Jul 12, 2023

Choose a reason for hiding this comment

github-actions bot Jul 12, 2023

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Jul 12, 2023

Choose a reason for hiding this comment

github-actions bot Jul 12, 2023

Choose a reason for hiding this comment

github-actions bot Jul 12, 2023

Choose a reason for hiding this comment

github-actions bot Jul 12, 2023

Choose a reason for hiding this comment

github-actions bot commented Jul 12, 2023 • edited Loading

Unit Test Results

github-actions bot commented Jul 12, 2023 •

edited

Loading