Improve slice performance of wall ordering #2001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quick optimization we could make; we were checking if one polygon was the child of another polygon. We were doing this for contour parallel tool paths. These tool paths have one property we can exploit, the polygons are never intersecting. A logical consequence from this property is that if one point of the child polygon is inside the parent polygon then all points are inside. The child-parent check is simplified by chekcing a single point. CURA-11352
This also resolves some bugs CURA-11352
# Conflicts: # include/utils/ExtrusionLine.h
saumyaj3
reviewed
Jan 2, 2024
include/utils/ExtrusionLine.h
Outdated
|
|
||
| const auto add_line_direction = [&poly](const auto iterator) | ||
| { | ||
| const auto window = iterator | ranges::views::sliding(2); |
There was a problem hiding this comment.
window is not used anywhere?
This constraint isn't true anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main performance improvement was done here: afab096. From commit message why this improves tihngs:
Other commit(s) simplified the code and resolved some remaining bugs
CURA-11352