Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile #23

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

marcindulak
Copy link
Contributor

@marcindulak marcindulak commented Feb 16, 2024

Closes #8

Focus points:

  1. Use debian instead of alpine https://martinheinz.dev/blog/92
  2. Run chrome without sandbox Running puppeteer in GitHub Docker image action with security context #11, since it is run as node user inside of the container. The tradeoff between sandboxing chrome vs giving more capabilities to the container could be reviewed later
  3. Tested (using the docker command from README.md) on Ubuntu 20.04 x86_64 and MacOS M1 arm64 (aarch64 inside of the container)
  4. bun ignored for now. It would be nice if the build could be made more reproducible (npm ci instead of npm install), while limiting the number of extra dependencies (like bun), e.g. by using package-lock.json (Done, subject to limitation [FEATURE] npm ci --global is not supported npm/cli#7224)

@gaurav-nelson
Copy link
Contributor

Thank you @marcindulak For the PR. I'll review and merge.

@marcindulak marcindulak force-pushed the create-dockerfile branch 4 times, most recently from 50dbea7 to 4e22e04 Compare May 6, 2024 21:57
Dockerfile Outdated Show resolved Hide resolved
@marcindulak marcindulak force-pushed the create-dockerfile branch 2 times, most recently from d2e5395 to 1797759 Compare May 8, 2024 20:15
@gaurav-nelson gaurav-nelson merged commit 557901a into UmbrellaDocs:main May 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Create a Dockerfile
2 participants