-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
METAR parser not handling 'FU' code #1951
Comments
@VORTEXJeff I've tweaked the parser locally and have it working properly now. I should have a PR up shortly that fixes this. |
Parser was not dealing well with a lot of weather code fields, so restructure just to look for sequences of any of those codes.
Ryan,
Great! Thanks for your prompt attention to fixing this.
Jeff Frame
Dr. Jeffrey Frame
Teaching Associate Professor
Department of Atmospheric Sciences
University of Illinois at Urbana-Champaign
3078 Natural History Building
1301 W. Green St.
Urbana, IL, 61801
…-------- Original message --------
From: Ryan May ***@***.***>
Date: 7/2/21 3:42 PM (GMT-06:00)
To: Unidata/MetPy ***@***.***>
Cc: "Frame, Jeffrey" ***@***.***>, Mention ***@***.***>
Subject: Re: [Unidata/MetPy] METAR parser not handling 'FU' code (#1951)
@VORTEXJeff<https://urldefense.com/v3/__https://github.com/VORTEXJeff__;!!DZ3fjg!rwOtO3YtzItGZuCRKb8e77NkRRuDasaOnwSwEyZ5seV6_GCnUggCW5qMdkezLajO$> I've tweaked the parser locally and have it working properly now. I should have a PR up shortly that fixes this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/Unidata/MetPy/issues/1951*issuecomment-873247046__;Iw!!DZ3fjg!rwOtO3YtzItGZuCRKb8e77NkRRuDasaOnwSwEyZ5seV6_GCnUggCW5qMdtoAbXNw$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AUWUKAOMBZWAVL25OMOBVLTTVYQDVANCNFSM47XK4EYA__;!!DZ3fjg!rwOtO3YtzItGZuCRKb8e77NkRRuDasaOnwSwEyZ5seV6_GCnUggCW5qMdlbpgbAs$>.
|
Parser was not dealing well with a lot of weather code fields, so restructure just to look for sequences of any of those codes.
Parser was not dealing well with a lot of weather code fields, so restructure just to look for sequences of any of those codes.
Parser was not dealing well with a lot of weather code fields, so restructure just to look for sequences of any of those codes.
Hi Ryan,
I'm not sure if you're the correct person to contact about this, but the Unidata METAR data appears to have gone missing: https://thredds-test.unidata.ucar.edu/thredds/catalog/nws/metar/ncdecoded/catalog.html
Dr. Jeffrey Frame
Teaching Associate Professor
Department of Atmospheric Sciences
University of Illinois at Urbana-Champaign
3078 Natural History Building
1301 W. Green St.
Urbana, IL, 61801
(217) 244-9575
|
@VORTEXJeff support-thredds@unidata.ucar.edu is probably the right place for this. The short answer is we moved servers and have been unable to get the venerable netcdf-perl built and running on that machine, so that data is pretty much gone. My suggestion would be to rely on the text products on thredds-dev (though I'm working right now on getting those on our production thredds.ucar.edu machine) and use something like MetPy to parse. Apologies for the inconvenience. |
Ryan,
Thanks - that’s where they are.
Dr. Jeffrey Frame
Teaching Associate Professor
Department of Atmospheric Sciences
University of Illinois at Urbana-Champaign
3078 Natural History Building
1301 W. Green St.
Urbana, IL, 61801
(217) 244-9575
From: Ryan May ***@***.***>
Sent: Wednesday, August 24, 2022 12:16 PM
To: Unidata/MetPy ***@***.***>
Cc: Frame, Jeffrey ***@***.***>; Mention ***@***.***>
Subject: Re: [Unidata/MetPy] METAR parser not handling 'FU' code (#1951)
@VORTEXJeff<https://urldefense.com/v3/__https:/github.com/VORTEXJeff__;!!DZ3fjg!9isd_g8HWZofZmk8PTkvuN7MvRQUSN7qdnEZH1zDUJFwMsZVV26Iyoej7wj5NHKd34utkmqMXY0sV19LGJGLCeiy1w$> ***@***.******@***.***> is probably the right place for this. The short answer is we moved servers and have been unable to get the venerable netcdf-perl built and running on that machine, so that data is pretty much gone. My suggestion would be to rely on the text products on thredds-dev<https://urldefense.com/v3/__https:/thredds-dev.unidata.ucar.edu/thredds/catalog/noaaport/text/metar/catalog.html__;!!DZ3fjg!9isd_g8HWZofZmk8PTkvuN7MvRQUSN7qdnEZH1zDUJFwMsZVV26Iyoej7wj5NHKd34utkmqMXY0sV19LGJH6yZLrZQ$> (though I'm working right now on getting those on our production thredds.ucar.edu machine) and use something like MetPy to parse. Apologies for the inconvenience.
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https:/github.com/Unidata/MetPy/issues/1951*issuecomment-1226010904__;Iw!!DZ3fjg!9isd_g8HWZofZmk8PTkvuN7MvRQUSN7qdnEZH1zDUJFwMsZVV26Iyoej7wj5NHKd34utkmqMXY0sV19LGJEt_VRPHg$>, or unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AUWUKAILALOUWPAD6PHMNC3V2ZKGNANCNFSM47XK4EYA__;!!DZ3fjg!9isd_g8HWZofZmk8PTkvuN7MvRQUSN7qdnEZH1zDUJFwMsZVV26Iyoej7wj5NHKd34utkmqMXY0sV19LGJH630ZtMw$>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
I am struggling to have the parser correctly handle smoke (FU) as a sensible weather condition. Parsing
KFLG 252353Z AUTO 27005KT 10SM FU BKN036 BKN085 22/03 A3018 RMK AO2 SLP130 T02220033 10250 20217 55007=
yields NaN for all fields except station ID, date/time, wind direction/speed, and a 10 for sky cover, meaning that the sky cover was not correctly parsed.
If I parse
KSYR 252354Z 18011KT 10SM FEW180 BKN250 27/12 A3012 RMK AO2 SLP193 T02670122 10294 20267 55002 $=
it parses correctly. but if I parse (same METAR, only with the manual addition of smoke)
KSYR 252354Z 18011KT 10SM FU FEW180 BKN250 27/12 A3012 RMK AO2 SLP193 T02670122 10294 20267 55002 $=
it fails as with the FLG example above.
Originally posted by @VORTEXJeff in #643 (comment)
The text was updated successfully, but these errors were encountered: