NEXRAD fixes #1833
Merged
NEXRAD fixes #1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit f021338 refactored the offset handling, but left an off-by-one error. This produced some warnings, but they were not caught--so now add to the tests to check the amount of warnings that get spit out.
dopplershift
added
Type: Bug
dcamron
previously approved these changes
Apr 27, 2021
|
Oh fun, a Windows-only failure. |
dopplershift
force-pushed
the
nexrad-fixes
branch
from
efdb6a3
to
eec326a
Compare
|
Changed to make sure we only parse the date/time (and set the |
This file, which has AR2V0001 as the version, has some oddities in it. Improve the parser to cope with these better.
dopplershift
force-pushed
the
nexrad-fixes
branch
from
eec326a
to
7ff3cdb
Compare
dcamron
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This Stack Overflow Question linked to some data in S3 that violated some assumptions by
Level2File. Some are oddities (like "look here for Vel and SW data" but "oh there are 0 bins of that data"). But we also had a bug where a variable was used uninitialized (triggered by an oddity), but it also turned out we had an off-by-one error--tests were masking warnings that resulted. We're now explicitly checking the count of log messages in our NEXRAD tests.Checklist