Reduce duplication in minimum dependencies #1842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
added
Area: Docs
This was naming the wrong version for a release: "v1" instead of "v1.0".
conda-forge's packages are now automatically built and should stay that way.
Instead, use sphinx's literalinclude to directly pull the list of dependencies from `setup.cfg`.
Instead of having a separate file (that doesn't get updated by Dependabot), just read our minimum versions directly from setup.cfg and use this to generate a Minimum constraint file on CI. This also updates setup.cfg to reflect the current versions from Minimum.
|
A consideration during review: is it worth keeping a |
dcamron
approved these changes
May 3, 2021
|
Yeah, I don't want the duplicated information. If you think it's worth it, I could extract the Python code that generates it into a script in |
|
Nah, the more I think about the point on testing minimums the less I think there's any serious use case for keeping that around on its own. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
As evidenced by #1839, we have a problem where we have duplication of information about the minimum supported versions of things. They currently exist in 3 places:
setup.cfgci/Minimum-- so we can test with our minimum versionsThis PR changes things so that
setup.cfg, which drives our PyPI package and gets (manually) synced to our conda-forge recipe, is the only source of this information. For CI, this deletes the static copy inci/Minimumand instead CI parsessetup.cfgand generates this file. For the install guide, this changes to use sphinx'sliteralincludedirective to directly include the relevant portion ofsetup.cfg. So that changes from:to
I don't love the new visual, but maybe at some point in the future we can address that with CSS. What I do love is that we only need to change one (sensibly canonical) spot to update our minimum supported versions of upstream dependencies, which is a good win for maintainability.
This PR also removes CI's hack for installing an older scipy for conda (and bumps us to scipy 1.6.3), which is no longer needed, as well as updates a few URLs that were redirecting.
Checklist