Improve some import handling #1928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) This avoids importing metpy.calc and metpy.plots in the metar parsing code, which improves import times for code that's only doing unrelated I/O, as well as eliminates a warning when CartoPy is not installed. The wx_code_map and wx_code_to_numeric function should eventually be moved to metar.py, but that's an API change.
dopplershift
added
Area: Infrastructure
dcamron
previously approved these changes
Jun 23, 2021
|
Thanks for catching that, it was an erroneous copy from this PEP. I fixed, and addressed a couple things the bots pointed out. Let's see now if the failure path for |
|
This should be fully tested now and ready for final review. |
dcamron
previously approved these changes
Jun 23, 2021
|
Ugh, failed on build without CartoPy installed. Fixed. |
|
While looking elsewhere, I was inspired and decided that instead of logging a warning about needing Cartopy, it should just be part of the |
Use the module-level __getattr__ support in Python 3.7 to dynamically handle access to the CartoPy map features and only warn *upon use* if CartoPy isn't installed.
dcamron
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
metpy.io.metar. This is currently causing importingmetpy.ioto trigger imports ofmetpy.calcandmetpy.plots, which can add almost half a second to the total import and currently triggers warnings when Cartopy isn't installed__getattr__()we have available now that we're only supporting Python >=3.7.Checklist
Level3Fileimport is a bit bloated #1901