Cleaning up analysis warnings #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found by CodeQL warning.
Restructure or otherwise avoid potentially undefined local variables.
dopplershift
added
Type: Bug
|
Ok, looks like the tests hung--I'm guessing due to the same |
This puts it with the rest of the fixtures. Also set it in the only test that seems to need it now.
Had been disabled since merge waiting on a viable Cartopy version, which has long-since been released.
dcamron
requested changes
Jun 29, 2021
Inspired by some alerts from CodeQL, though most were false alarms.
|
Should be good now. |
dcamron
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Fixing up some style issues from CodeQL, including one real bug (in code for a NEXRAD product that likely no one uses).
set_agg_backendwith the rest of the fixtures inconftest.pyand only use on the one test that requires it (test_showintest_declarative.py, because otherwise it opens a window).test_mapping.py--this was waiting on CartoPy>0.16 (0.17 came out November 2018). This is why, boys and girls, you don't comment things out but useskipsand stuff.