Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dave allured format compat on reopen #2193

Merged
merged 6 commits into from
Jan 21, 2022

Commits on Jan 8, 2022

  1. Format compatibility when re-opening files

    This commit selects the best HDF5 format compatibility options when re-opening an existing netCDF-4 file for writing, such as appending, or adding new groups or variables.
    
    The general objective is to make netCDF-4 files that can be read and written by all previous library  versions.  Optimal HDF5 v1.8 compatibility is selected whenever possible.  Otherwise this falls back to the adequate v1.6 compatibility.
    
    Format compatibility is a transient property of the HDF5 library, rather than baked in at file creation time.  Therefore, compatibility options must be re-selected every time a netCDF-4 file is re-opened for writing.
    
    This builds on the previous update for initial file creation, PR Unidata#1931, by @brtnfld, released in netcdf-c version 4.8.1.
    
    In particular, this commit moves compatibility controls into a single central location, a new common function that is shared by both create and open functions.
    
    For more details, see issue Unidata#951, also documentation at the top of libhdf5/hdf5set_format_compatibility.c.
    
    This commit also makes several corrections and cleanups to previous comments about the use of related property lists.
    Dave-Allured committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    9f46184 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b3b0da9 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2022

  1. Configuration menu
    Copy the full SHA
    69b2d20 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2022

  1. Configuration menu
    Copy the full SHA
    158f290 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2022

  1. Merge branch 'format-compat-on-reopen' of https://github.com/Dave-All…

    …ured/netcdf-c into Dave-Allured-format-compat-on-reopen
    WardF committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    41baf43 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2570ac1 View commit details
    Browse the repository at this point in the history