Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on Fusion based backend modules #9

Open
markusguenther opened this issue Mar 8, 2021 · 4 comments
Open

Error on Fusion based backend modules #9

markusguenther opened this issue Mar 8, 2021 · 4 comments

Comments

@markusguenther
Copy link
Member

Description

Before others wonder what this could be, I'll create a ticket prophylactically.

It can happen that a backend module throws the error that the LayoutRootpath is not defined. This happens with high probability because you have a module that uses Fusion instead of Fluid. I already stubled upon this while the development, but did not see an easy way to detect the view type of a module.

Only way right know is to limit the LayoutPath change for the Neos/Neos packages. Or just limit the change to the user management module.

Expected behavior

The Backend works with Fluid and Fusion based Modules

Actual behavior

Screenshot 2021-03-08 at 09 26 54

This happens for Fusion based modules.

Affected Versions

LoginAs: 2.0.0

@Sebobo
Copy link

Sebobo commented Mar 9, 2021

This is a bit of a problem in one of my projects and breaks several modules.

Wouldn't it be simpler to just enable the feature for Neos/Neos modules?
If people want to have the feature in their own they have to adjust the views.yaml.

@Sebobo
Copy link

Sebobo commented Mar 9, 2021

F.e. instead use

requestFilter: 'isPackage("Neos.Neos") && parentRequest.isController("Backend\Module") && isFormat("html") && !isPackage("Neos.Media.Browser") && !isController("Module\Management\History")'

markusguenther added a commit that referenced this issue Mar 9, 2021
To prevent exceptions in third party modules we limit the override of the layoutRootPaths to the
Neos/Neos backend modules

re #9
@markusguenther
Copy link
Member Author

The layoutRootPath is now limited to isPackage("Neos.Neos") but would be nice to detect the fusion views or just add assets to all neos modules. But for that we need to create a change in neos/neos itself.

@markusguenther
Copy link
Member Author

With Neos 8.0 the package became part of the core and does not have the issue anymore.
But for the earlier versions, it still exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants