-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg(com.hoffnung
): change removal
#320
pkg(com.hoffnung
): change removal
#320
Conversation
In my case, it cause the screen went blank, but the power option UI is still accessible on my Infinix phone. But there's a worse case: https://xdaforums.com/t/infinix-note-10-uninstall-tpms-com-hoffnung-package-causes-bootloop.4647456/ So, just don't recommend 'com.hoffnung'
Thanks for your PR. I'll review it after I got some questions answered that I'm curious about:
|
Hi! I have a Infinix HOT 12 Play and disabling com.hoffnung has never caused issues for me and is just a random background process that also has some telemetry, what seems to be your phone? |
Also did you use Disable instead of Uninstall? |
dont put it in expert, he just didnt read description |
com.hoffnung
): change removal
@rivanfebrian123 Please follow up on this. |
if he doesnt follow up, i suggest we keep it because disabling it for me does help because it is a unnecessary background process, we can assume that he didnt disable but rather uninstall |
Sorry for late follow up Replies
It's the XOS thingies I guess
Sure, that would be great
I uninstalled it
I think most of beginners would just select all and uninstall them
Yep, but the thing is, the default action for 'recommended' package is to uninstall them. So beginners would assume that it's safe to do that (clicking the button) |
I'm either thinking about moving it to
|
i agree that beginners should be able to just select everything in recommended and be able to just press uninstall and be done, however com.hoffnung is in a tough position where disabling it is absolutely recommended but it has to actually be disabled |
What if... we make it possible to use different removal action for different package? With that being said, the JSON file would look like this:
|
this also goes for tech.palm.id which is recommended to be disabled |
This requires a feature request. Also, all packages would need this extra field. |
Closing this PR as the user did not carefully read its description (it clearly said you should disable, not uninstall). I'll make a change to the description. |
In my case, it cause the screen went blank, but the power option UI is still accessible on my Infinix phone. But there's a worse case: https://xdaforums.com/t/infinix-note-10-uninstall-tpms-com-hoffnung-package-causes-bootloop.4647456/
So, just don't recommend 'com.hoffnung'