Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ci): invalid json file IGNORE PR, for testing purposes only #377

Closed
wants to merge 3 commits into from
Closed

test(ci): invalid json file IGNORE PR, for testing purposes only #377

wants to merge 3 commits into from

Conversation

edgy-b
Copy link
Contributor

@edgy-b edgy-b commented Mar 24, 2024

No description provided.

@edgy-b edgy-b changed the title test(ci): invalid json file test(ci): invalid json file IGNORE PR, for testing purposes only Mar 24, 2024
@AnonymousWP
Copy link
Member

AnonymousWP commented Mar 24, 2024 •
edited
Loading

Marking this PR as draft, as it's still work in progress.

@AnonymousWP AnonymousWP marked this pull request as draft March 24, 2024 13:33
@AnonymousWP AnonymousWP linked an issue Mar 24, 2024 that may be closed by this pull request
feat(ci): validate JSON schema before merging PR #376
Closed
3 tasks
@AnonymousWP AnonymousWP added the enhancement New feature or request label Mar 24, 2024
@Frigyes06
Copy link
Member

Run cargo test on json changes. It'll fail if the json is messed up.

@AnonymousWP AnonymousWP deleted the error/json branch March 31, 2024 11:08
@AnonymousWP AnonymousWP restored the error/json branch March 31, 2024 11:08
@AnonymousWP AnonymousWP reopened this Mar 31, 2024
@AnonymousWP
Copy link
Member

Any updates on this?

@AnonymousWP
Copy link
Member

@edgy-b See above.

@AnonymousWP
Copy link
Member

Superseded by #446.

@AnonymousWP AnonymousWP closed this May 4, 2024
@AnonymousWP AnonymousWP deleted the error/json branch May 4, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(ci): validate JSON schema before merging PR
3 participants
@edgy-b @AnonymousWP @Frigyes06