Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(app): exclude windows terminal attach #414

Merged
merged 5 commits into from
Apr 9, 2024
Merged

feat(app): exclude windows terminal attach #414

merged 5 commits into from
Apr 9, 2024

Conversation

Frigyes06
Copy link
Member

No description provided.

@Frigyes06 Frigyes06 added the enhancement New feature or request label Apr 8, 2024
@Frigyes06 Frigyes06 requested a review from a team April 8, 2024 20:24
@deepsource-autofix
style: format code with Rustfmt
13a928a 
This commit fixes the style issues introduced in 6ed6c1f according to the output
from Rustfmt.

Details: #414
@deepsource-io deepsource.io
Copy link
Contributor

deepsource-io bot commented Apr 8, 2024 •
edited
Loading

Here's the code health analysis summary for commits 45b2231..e86c3f7. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Rust LogoRust✅ Success
🎯 1 occurence resolved
View Check ↗
DeepSource Test coverage LogoTest coverage⚠️ Artifact not reportedTimed out: Artifact was never reportedView Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@Frigyes06
Copy link
Member Author

I will eat my hat

edgy-b
edgy-b reviewed Apr 9, 2024
View reviewed changes
src/main.rs Outdated Show resolved Hide resolved
edgy-b
edgy-b previously approved these changes Apr 9, 2024
View reviewed changes
AnonymousWP
AnonymousWP requested changes Apr 9, 2024
View reviewed changes
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
@Frigyes06 @AnonymousWP
Capitalization fixes
e86c3f7 
Co-authored-by: Anonymoussaurus <50231698+AnonymousWP@users.noreply.github.com>
@AnonymousWP AnonymousWP merged commit 01209d4 into main Apr 9, 2024
18 of 19 checks passed
@AnonymousWP AnonymousWP deleted the fix/exclude-windows-console-entirely-on-non-windows-systems branch April 9, 2024 17:55
@AnonymousWP
Copy link
Member

Approved & merged, but if you could add some small explanation in the description, then that'd be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnonymousWP AnonymousWP AnonymousWP approved these changes

@edgy-b edgy-b edgy-b left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Frigyes06 @AnonymousWP @edgy-b