Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backup): add ability to export uninstalled packages with their description #527

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

edgy-b
Copy link
Contributor

@edgy-b edgy-b commented Jun 30, 2024

  • fixed some deepsource issues

Resolves #173

@edgy-b edgy-b requested a review from a team June 30, 2024 17:33
Copy link
Contributor

deepsource-io bot commented Jun 30, 2024

Here's the code health analysis summary for commits 2de6e73..4e954c0. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Rust LogoRust❌ Failure
❗ 11 occurences introduced
🎯 12 occurences resolved
View Check ↗
DeepSource Test coverage LogoTest coverage✅ Success
❗ 22 occurences introduced
🎯 15 occurences resolved
View Check ↗

Code Coverage Report

MetricAggregateRust
Branch Coverage100%0%
Composite Coverage1.8% (down 0.2% from main)1.8% (down 0.2% from main)
Line Coverage1.8% (down 0.2% from main)1.8% (down 0.2% from main)
New Branch Coverage100%100%
New Composite Coverage0.8%0.8%
New Line Coverage0.8%0.8%

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@AnonymousWP AnonymousWP added the enhancement New feature or request label Jun 30, 2024
Copy link
Contributor

@adhirajsinghchauhan adhirajsinghchauhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code passes the eye test, but are we sure we want to stick with txt? This looks weird to me:

Name: <app 1>
Description: <multiline
text>
-------------------------------------------------------------------
Name: <app 2>
Description: <text>

I'd rather have it exported in other formats such as CSV. Can still be opened in a text editor, but at least users could potentially use other programs to view/filter through everything.

.map(|p| {
format!(
"{}Name: {}\nDescription: {}",
"-------------------------------------------------------------------\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we end up sticking with txt, consider making this separator string a const somewhere up above, so that we can reuse it elsewhere.

…escription

 - changed export file to csv

 - silenced clippy error for now (dead code), until fixed or found solution
@adhirajsinghchauhan adhirajsinghchauhan merged commit e500d50 into main Jul 3, 2024
20 of 21 checks passed
@adhirajsinghchauhan adhirajsinghchauhan deleted the feat/export-packages branch July 3, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export packages with their descriptions in a txt file for a reference
4 participants