-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backup): add ability to export uninstalled packages with their description #527
Conversation
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
…escription - fixed some deepsource issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code passes the eye test, but are we sure we want to stick with txt? This looks weird to me:
Name: <app 1>
Description: <multiline
text>
-------------------------------------------------------------------
Name: <app 2>
Description: <text>
I'd rather have it exported in other formats such as CSV. Can still be opened in a text editor, but at least users could potentially use other programs to view/filter through everything.
src/core/utils.rs
Outdated
.map(|p| { | ||
format!( | ||
"{}Name: {}\nDescription: {}", | ||
"-------------------------------------------------------------------\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we end up sticking with txt, consider making this separator string a const
somewhere up above, so that we can reuse it elsewhere.
…escription - changed export file to csv - silenced clippy error for now (dead code), until fixed or found solution
Resolves #173