Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg(samsung): alt names, missing packs, fmt list #555

Merged
merged 9 commits into from
Sep 6, 2024

Conversation

Rudxain
Copy link
Member

@Rudxain Rudxain commented Jul 15, 2024

closes #554

This PR:

  • improves descriptions by adding alternative names
  • adds previously-unlisted packages
  • formats the JSON

Copy link
Contributor

deepsource-io bot commented Jul 15, 2024

Here's the code health analysis summary for commits d1a7eb1..a5b75d1. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Rust LogoRust✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage⚠️ Artifact not reportedTimed out: Artifact was never reportedView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@Rudxain Rudxain changed the title docs(pkg-samsung): alt names, and #554 docs(pkg-samsung): alt names, and pkg that isn't Motorola-exclusive Jul 15, 2024
@AnonymousWP AnonymousWP changed the title docs(pkg-samsung): alt names, and pkg that isn't Motorola-exclusive pkg(samsung): add alt names to description and add dependencies Jul 15, 2024
@AnonymousWP AnonymousWP added the package::documentation Improve a description/recommendation label Jul 15, 2024
@Rudxain
Copy link
Member Author

Rudxain commented Jul 16, 2024

I've just noticed my JSON LSP auto-formatted the file 💀. The Huawei stuff should've stayed intact. I'm sorry

@Rudxain Rudxain changed the title pkg(samsung): add alt names to description and add dependencies pkg(samsung): add alt names to description and format Jul 16, 2024
@Rudxain Rudxain changed the title pkg(samsung): add alt names to description and format pkg(samsung): add alt names to description and format list Jul 21, 2024
@Rudxain Rudxain changed the title pkg(samsung): add alt names to description and format list pkg(samsung): add alt names to description and fmt list Jul 21, 2024
@Rudxain
Copy link
Member Author

Rudxain commented Sep 5, 2024

As a follow-up to 0x192/universal-android-debloater#811, I've found these unlisteds:

com.samsung.android.mdagent
com.samsung.android.wifi.p2paware.resources
com.samsung.phone.overlay.common

I'll try to find info about them, so that they can be properly documented.

Update: On the Settings app, none can be disabled, but they can be battery-restricted. I would put them in Advanced. I haven't decompiled them, yet

@Rudxain Rudxain marked this pull request as ready for review September 5, 2024 04:49
@Rudxain Rudxain added the package::addition Adding new apps to the debloat list label Sep 5, 2024
@Rudxain Rudxain changed the title pkg(samsung): add alt names to description and fmt list pkg(samsung): alt names, missing packs, fmt list Sep 5, 2024
@Rudxain Rudxain requested a review from a team September 5, 2024 07:07
@AnonymousWP
Copy link
Member

I'll review it once you've solved conflicts.

@Rudxain
Copy link
Member Author

Rudxain commented Sep 5, 2024

GH suggests git merge main should I git rebase -i main instead?

@AnonymousWP
Copy link
Member

A git merge will do, yes. You just need to merge main into docs/pkg/SM-A315G. Git will then tell/show you that there are merge conflicts. Solve them accordingly and commit - resulting in solved conflicts. Make sure you don't throw away the wrong entries though.

@Rudxain
Copy link
Member Author

Rudxain commented Sep 5, 2024

BTW, I had MdAgent uninstalled for ~1 year, and didn't notice anything wrong. That's why it's Advanced rather than Expert, despite the lack of info

Copy link
Member

@AnonymousWP AnonymousWP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks. 🙂

@AnonymousWP AnonymousWP merged commit ee4958a into main Sep 6, 2024
20 of 21 checks passed
@AnonymousWP AnonymousWP deleted the docs/pkg/SM-A315G branch September 6, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package::addition Adding new apps to the debloat list package::documentation Improve a description/recommendation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkg(com.google.android.overlay.gmsconfig.photos): it's also installed on Samsung Galaxy devices
2 participants