Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sentry config on the server side #377

Merged
merged 6 commits into from
Jun 25, 2021
Merged

Fix Sentry config on the server side #377

merged 6 commits into from
Jun 25, 2021

Conversation

Vadorequest
Copy link
Member

@Vadorequest Vadorequest commented Jun 25, 2021 •
edited
Loading

Events aren't properly reported to Sentry for API endpoints, might have broken something during refactoring.

Fixes:

  • Error reporting on 404 pages (wasn't working, probably broken since early v2)
  • Error reporting on API endpoints (broken due to recent refactoring)
  • Error reporting on _error (still don't know exactly in what cases this file is being used)

@Vadorequest
Re-export Sentry from init (DX) and call init from error endpoint to …
d8ca4fd 
…see if it fixes the issue with flush() timeout
@github-actions github-actions bot temporarily deployed to customer1-staging June 25, 2021 05:43 Inactive
@github-actions
Copy link

✅  Deployment SUCCESS
Commit d8ca4fd successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-hbha0r12t-unly-oss.vercel.app
Deployment aliases (2): nrn-v2-mst-aptd-at-lcz-sty-c1-preview.vercel.app, nrn-v2-mst-aptd-at-lcz-sty-c1-fix-sentry-server-side.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit d8ca4fd previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-hbha0r12t-unly-oss.vercel.app

@github-actions github-actions bot temporarily deployed to customer1-staging June 25, 2021 06:43 Inactive
@github-actions
Copy link

✅  Deployment SUCCESS
Commit 9f68fce successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-2nzuqx0c3-unly-oss.vercel.app
Deployment aliases (2): nrn-v2-mst-aptd-at-lcz-sty-c1-preview.vercel.app, nrn-v2-mst-aptd-at-lcz-sty-c1-fix-sentry-server-side.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 9f68fce previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-2nzuqx0c3-unly-oss.vercel.app

@github-actions github-actions bot temporarily deployed to customer1-staging June 25, 2021 07:06 Inactive
@github-actions
Copy link

✅  Deployment SUCCESS
Commit f32f876 successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-2x6s45mvm-unly-oss.vercel.app
Deployment aliases (2): nrn-v2-mst-aptd-at-lcz-sty-c1-preview.vercel.app, nrn-v2-mst-aptd-at-lcz-sty-c1-fix-sentry-server-side.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit f32f876 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-2x6s45mvm-unly-oss.vercel.app

@github-actions github-actions bot temporarily deployed to customer1-staging June 25, 2021 07:37 Inactive
@github-actions github-actions bot temporarily deployed to storybook June 25, 2021 07:37 Inactive
@Vadorequest Vadorequest marked this pull request as ready for review June 25, 2021 07:39
@github-actions
Copy link

✅  Deployment SUCCESS
Commit d6a21b1 successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-p5jzaerca-unly-oss.vercel.app
Deployment aliases (2): nrn-v2-mst-aptd-at-lcz-sty-c1-preview.vercel.app, nrn-v2-mst-aptd-at-lcz-sty-c1-fix-sentry-server-side.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit d6a21b1 successfully deployed Storybook static site 📖 to https://nrn-v2-mst-aptd-at-lcz-sty-storybook-duh07eokz-unly-oss.vercel.app
Deployment aliases (1): nrn-v2-mst-aptd-at-lcz-sty-storybook.vercel.app

@Vadorequest Vadorequest merged commit 1542318 into v2-mst-aptd-at-lcz-sty Jun 25, 2021
@Vadorequest Vadorequest deleted the fix-sentry-server-side branch June 25, 2021 07:48
@github-actions
Copy link

✅  E2E tests SUCCESS for commit d6a21b1 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-p5jzaerca-unly-oss.vercel.app

Vadorequest added a commit that referenced this pull request Jun 25, 2021
@Vadorequest
Fix Sentry config on the server side (#377)
5ea63ac 
* Re-export Sentry from init (DX) and call init from error endpoint to see if it fixes the issue with flush() timeout

* Improve sentry init documentation + rollback to timeout 2s + auto-init Sentry when using configureReq

* Implement better error handling on _error page (enrich Sentry metadata from req object)

* Fix 404 error handling and reporting to Sentry

* Improve documentation about error handling

* Upgrade Sentry to latest (minor)
@github-actions
Copy link

✅  E2E tests SUCCESS for commit d6a21b1 previously deployed Storybook static site at https://nrn-v2-mst-aptd-at-lcz-sty-storybook-duh07eokz-unly-oss.vercel.app

@Vadorequest Vadorequest mentioned this pull request Jun 25, 2021
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Vadorequest