Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router): static routes support #404

Merged
merged 5 commits into from
Oct 16, 2023
Merged

Conversation

villevsv-upcloud
Copy link
Contributor

No description provided.

@villevsv-upcloud villevsv-upcloud marked this pull request as ready for review October 3, 2023 15:00
@villevsv-upcloud villevsv-upcloud requested a review from a team as a code owner October 3, 2023 15:00
@@ -10,6 +10,10 @@ variable "zone" {

resource "upcloud_router" "this" {
name = "${var.prefix}router"

lifecycle {
ignore_changes = [static_route]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the gateway automatically set static_routes to the router? Could we somehow handle that automatic route so that end-user does not have to use lifecycle.ignore_changes 🤔 Or is it something we could instruct user to do themselves, like the router creation with Kubernetes clusters.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment to the documentation for now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The static routes automatically set by the gateway seem to be in link-local address space (169.254.0.0/16). Thus, they should not collide with values expected from user. Maybe some sort special value would work here, but that would require more investigating/testing.

Copy link
Contributor

@kangasta kangasta Oct 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably good to merge this like this to unblock the release and then try to add fix or workaround for this later 🤔 I was also trying to think of some nice way of fixing this, but no good ideas this far.

@villevsv-upcloud villevsv-upcloud merged commit dbe911b into main Oct 16, 2023
2 checks passed
@villevsv-upcloud villevsv-upcloud deleted the feat/static-routes branch October 16, 2023 15:05
github-actions bot pushed a commit that referenced this pull request Oct 16, 2023
@github-actions github-actions bot mentioned this pull request Oct 16, 2023
kangasta pushed a commit that referenced this pull request Oct 19, 2023
Co-authored-by: villevsv-upcloud <villevsv-upcloud@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants