Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(kubernetes): migrate node_group to plugin framework #602

Merged

Conversation

villevsv-upcloud
Copy link
Contributor

No description provided.

@villevsv-upcloud villevsv-upcloud changed the title refactor(kubernetes): migrate nodeg to plugin framework refactor(kubernetes): migrate node_group to plugin framework Jul 30, 2024
@kangasta
Copy link
Contributor

Could add CHANGELOG entry about the custom_plan fixes as well

@villevsv-upcloud
Copy link
Contributor Author

Could add CHANGELOG entry about the custom_plan fixes as well

There were no actual changes for the custom plan logic in the end, just ported from CustomizeDiff to a plan modifier.

@villevsv-upcloud villevsv-upcloud marked this pull request as ready for review July 30, 2024 10:23
@villevsv-upcloud villevsv-upcloud requested a review from a team as a code owner July 30, 2024 10:23
@villevsv-upcloud villevsv-upcloud force-pushed the refactor/migrate-kubernetes-node-group-to-plugin-framework branch from b503db2 to 532c58d Compare August 6, 2024 12:56
@villevsv-upcloud villevsv-upcloud force-pushed the refactor/migrate-kubernetes-node-group-to-plugin-framework branch from bc35a1d to 9eb590e Compare August 16, 2024 11:26
@villevsv-upcloud villevsv-upcloud force-pushed the refactor/migrate-kubernetes-node-group-to-plugin-framework branch from 9eb590e to 233d64b Compare August 16, 2024 13:06
@villevsv-upcloud villevsv-upcloud merged commit e698b91 into main Aug 16, 2024
4 of 5 checks passed
@villevsv-upcloud villevsv-upcloud deleted the refactor/migrate-kubernetes-node-group-to-plugin-framework branch August 16, 2024 13:10
github-actions bot pushed a commit that referenced this pull request Aug 16, 2024
villevsv-upcloud added a commit that referenced this pull request Aug 16, 2024
Co-authored-by: villevsv-upcloud <villevsv-upcloud@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants