-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(kubernetes): migrate node_group to plugin framework #602
Merged
villevsv-upcloud
merged 11 commits into
main
from
refactor/migrate-kubernetes-node-group-to-plugin-framework
Aug 16, 2024
Merged
refactor(kubernetes): migrate node_group to plugin framework #602
villevsv-upcloud
merged 11 commits into
main
from
refactor/migrate-kubernetes-node-group-to-plugin-framework
Aug 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villevsv-upcloud
changed the title
refactor(kubernetes): migrate nodeg to plugin framework
refactor(kubernetes): migrate node_group to plugin framework
Jul 30, 2024
kangasta
reviewed
Jul 30, 2024
kangasta
reviewed
Jul 30, 2024
kangasta
approved these changes
Jul 30, 2024
Could add CHANGELOG entry about the |
kangasta
reviewed
Jul 30, 2024
There were no actual changes for the custom plan logic in the end, just ported from CustomizeDiff to a plan modifier. |
villevsv-upcloud
force-pushed
the
refactor/migrate-kubernetes-node-group-to-plugin-framework
branch
from
August 6, 2024 12:56
b503db2
to
532c58d
Compare
villevsv-upcloud
force-pushed
the
refactor/migrate-kubernetes-node-group-to-plugin-framework
branch
from
August 16, 2024 11:26
bc35a1d
to
9eb590e
Compare
villevsv-upcloud
force-pushed
the
refactor/migrate-kubernetes-node-group-to-plugin-framework
branch
from
August 16, 2024 13:06
9eb590e
to
233d64b
Compare
villevsv-upcloud
deleted the
refactor/migrate-kubernetes-node-group-to-plugin-framework
branch
August 16, 2024 13:10
villevsv-upcloud
added a commit
that referenced
this pull request
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.