Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(server): take stopped/started state into account in completions #332

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(server): take stopped/started state into account in completions #332

wants to merge 1 commit into from
+53 −9

Conversation

scop
Copy link
Member

@scop scop commented Sep 19, 2024

We could add some more to avoid various other completions for servers let's say in maintenance state, but this covers the most common cases for now.

@scop scop requested a review from a team as a code owner September 19, 2024 08:04
villevsv-upcloud
villevsv-upcloud approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@villevsv-upcloud villevsv-upcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! A short changelog entry would be useful.

I'll create a separate PR to accommodate the unrelated linter issues, so this branch can be rebased after that been merged to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villevsv-upcloud villevsv-upcloud villevsv-upcloud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scop @villevsv-upcloud