Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix storage location of settings.yaml #103

Closed
tsagadar opened this issue Aug 29, 2024 · 0 comments · Fixed by #106
Closed

Fix storage location of settings.yaml #103

tsagadar opened this issue Aug 29, 2024 · 0 comments · Fixed by #106
Assignees
@b-rowan
Labels
bug Something isn't working
Milestone
v0.2.0

Comments

@tsagadar
Copy link
Collaborator

When deployed using pip, the settings.yaml is searched within the site-packages folder structure (see #101 (comment)).

Also should review all the other usages of BASE_DIR
@tsagadar tsagadar mentioned this issue Aug 29, 2024
Merged
@b-rowan b-rowan added bug Something isn't working v0.2.0 labels Aug 29, 2024
@b-rowan b-rowan self-assigned this Aug 29, 2024
UpstreamData added a commit that referenced this issue Aug 29, 2024
@UpstreamData
Remove BASE_DIR parsing for settings
c81759b 
`settings.yaml` being parsed from a base directory has issues when being installed from pip.  The user must now pass a `settings_file` path to goosebit when running.

With these changes, gooseBit should be run with `python -m goosebit [settings_file]`.  There is also now help information with `python -m goosebit --help`.

Fixes: #103
@b-rowan b-rowan mentioned this issue Aug 29, 2024
Closed
UpstreamData added a commit that referenced this issue Aug 29, 2024
@UpstreamData
Remove BASE_DIR parsing for settings
427ec9d 
`settings.yaml` being parsed from a base directory has issues when being installed from pip.  The user must now pass a `settings_file` path to goosebit when running.

With these changes, gooseBit should be run with `python -m goosebit [settings_file]`.  There is also now help information with `python -m goosebit --help`.

Fixes: #103
UpstreamData added a commit that referenced this issue Aug 29, 2024
@UpstreamData
Remove BASE_DIR parsing for settings
94e95c6 
`settings.yaml` being parsed from a base directory has issues when being installed from pip.  The user must now pass a `settings_file` path to goosebit when running.

With these changes, gooseBit should be run with `python -m goosebit [settings_file]`.  There is also now help information with `python -m goosebit --help`.

Fixes: #103
UpstreamData added a commit that referenced this issue Aug 29, 2024
@UpstreamData
Remove BASE_DIR parsing for settings
bdb8e6b 
`settings.yaml` being parsed from a base directory has issues when being installed from pip.  The user must now pass a `settings_file` path to goosebit when running.

With these changes, gooseBit should be run with `python -m goosebit [settings_file]`.  There is also now help information with `python -m goosebit --help`.

Fixes: #103
UpstreamData added a commit that referenced this issue Aug 29, 2024
@UpstreamData
Remove BASE_DIR parsing for settings
03e016f 
`settings.yaml` being parsed from a base directory has issues when being installed from pip.  Now, gooseBit will try to source from a platform specific directory for settings.  If it cannot find a configuration file, it will warn the user, along with telling them the path to use.

Fixes: #103
@b-rowan b-rowan mentioned this issue Aug 29, 2024
Merged
b-rowan pushed a commit that referenced this issue Aug 31, 2024
@UpstreamData @b-rowan
Remove BASE_DIR parsing for settings
40da115 
`settings.yaml` being parsed from a base directory has issues when being installed from pip.  Now, gooseBit will try to source from a platform specific directory for settings.  If it cannot find a configuration file, it will warn the user, along with telling them the path to use.

Fixes: #103
b-rowan pushed a commit that referenced this issue Aug 31, 2024
@UpstreamData @b-rowan
Rename settings.yaml to goosebit.yaml, and check multiple places for …
88f99b9 
…settings.

Use can now pass `GOOSEBIT_SETTINGS` to customize settings location, as well as goosebit auto checking `/etc/goosebit` if it exists, the root of the project directory, and the current working directory when it is run. This should allow for more optionality when loading settings files.

Renaming settings to `goosebit.yaml` is mainly to specify what the file is when running from CWD, it should be distinct from other files.

Fixes: #103
b-rowan pushed a commit that referenced this issue Aug 31, 2024
@UpstreamData @b-rowan
Rename settings.yaml to goosebit.yaml, and check multiple places for …
bc48b10 
…settings.

Use can now pass `GOOSEBIT_SETTINGS` to customize settings location, as well as goosebit auto checking `/etc/goosebit` if it exists, the root of the project directory, and the current working directory when it is run.
This should allow for more optionality when loading settings files.

Renaming settings to `goosebit.yaml` is mainly to specify what the file is when running from CWD, it should be distinct from other files.

Fixes: #103
b-rowan pushed a commit that referenced this issue Aug 31, 2024
@UpstreamData @b-rowan
Rename settings.yaml to goosebit.yaml, and check multiple places for …
462e498 
…settings.

Use can now pass `GOOSEBIT_SETTINGS` to customize settings location, as well as goosebit auto checking `/etc/goosebit` if it exists, the root of the project directory, and the current working directory when it is run.
This should allow for more optionality when loading settings files.

Renaming settings to `goosebit.yaml` is mainly to specify what the file is when running from CWD, it should be distinct from other files.

Fixes: #103
b-rowan pushed a commit that referenced this issue Aug 31, 2024
@UpstreamData @b-rowan
Rename settings.yaml to goosebit.yaml, and check multiple places for …
e68e541 
…settings.

Use can now pass `GOOSEBIT_SETTINGS` to customize settings location, as well as goosebit auto checking `/etc/goosebit` if it exists, the root of the project directory, and the current working directory when it is run.
This should allow for more optionality when loading settings files.

Renaming settings to `goosebit.yaml` is mainly to specify what the file is when running from CWD, it should be distinct from other files.

Fixes: #103
UpstreamData added a commit that referenced this issue Sep 3, 2024
@UpstreamData
Rename settings.yaml to goosebit.yaml, and check multiple places for …
80fc312 
…settings.

Use can now pass `GOOSEBIT_SETTINGS` to customize settings location, as well as goosebit auto checking `/etc/goosebit` if it exists, the root of the project directory, and the current working directory when it is run.
This should allow for more optionality when loading settings files.

Renaming settings to `goosebit.yaml` is mainly to specify what the file is when running from CWD, it should be distinct from other files.

Fixes: #103
@b-rowan b-rowan added this to the v0.2.0 milestone Sep 3, 2024
@b-rowan b-rowan removed the v0.2.0 label Sep 3, 2024
UpstreamData added a commit that referenced this issue Sep 3, 2024
@UpstreamData
Rename settings.yaml to goosebit.yaml, and check multiple places for …
0d240bb 
…settings.

Use can now pass `GOOSEBIT_SETTINGS` to customize settings location, as well as goosebit auto checking `/etc/goosebit` if it exists, the root of the project directory, and the current working directory when it is run.
This should allow for more optionality when loading settings files.

Renaming settings to `goosebit.yaml` is mainly to specify what the file is when running from CWD, it should be distinct from other files.

Fixes: #103
b-rowan pushed a commit that referenced this issue Sep 4, 2024
@UpstreamData @b-rowan
Rename settings.yaml to goosebit.yaml, and check multiple places for …
d13a211 
…settings.

Use can now pass `GOOSEBIT_SETTINGS` to customize settings location, as well as goosebit auto checking `/etc/goosebit` if it exists, the root of the project directory, and the current working directory when it is run.
This should allow for more optionality when loading settings files.

Renaming settings to `goosebit.yaml` is mainly to specify what the file is when running from CWD, it should be distinct from other files.

Fixes: #103
b-rowan pushed a commit that referenced this issue Sep 4, 2024
@UpstreamData @b-rowan
Rename settings.yaml to goosebit.yaml, and check multiple places for …
4e0ad7d 
…settings.

Use can now pass `GOOSEBIT_SETTINGS` to customize settings location, as well as goosebit auto checking `/etc/goosebit` if it exists, the root of the project directory, and the current working directory when it is run.
This should allow for more optionality when loading settings files.

Renaming settings to `goosebit.yaml` is mainly to specify what the file is when running from CWD, it should be distinct from other files.

Fixes: #103
UpstreamData added a commit that referenced this issue Sep 4, 2024
@UpstreamData
Rename settings.yaml to goosebit.yaml, and check multiple places for …
798f950 
…settings.

Use can now pass `GOOSEBIT_SETTINGS` to customize settings location, as well as goosebit auto checking `/etc/goosebit` if it exists, the root of the project directory, and the current working directory when it is run.
This should allow for more optionality when loading settings files.

Renaming settings to `goosebit.yaml` is mainly to specify what the file is when running from CWD, it should be distinct from other files.

Fixes: #103
@b-rowan b-rowan closed this as completed in 6d04e17 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@b-rowan b-rowan

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.2.0
2 participants
@tsagadar @b-rowan