Support local files with matching filenames #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to call `generate_schemas` to make sure that the initial DB is set up properly.
To prevent overlaps with local files that have the same name but are different files, the path for artifacts is now `<artifact_dir>/<file_hash>/<filename>`. Files with the same version and compatibility wil still raise an error to the frontend. Fixes: #104
tsagadar
requested changes
Sep 6, 2024
goosebit/db/__init__.py
Outdated
| @@ -5,6 +5,7 @@ | |||
|
|
|||
| async def init(): | |||
| await Tortoise.init(config=TORTOISE_CONF) | |||
| await Tortoise.generate_schemas() | |||
There was a problem hiding this comment.
Should not be necessary. As written in the README.md : "Create or upgrade database: poetry run aerich upgrade"
My working assumption is, that DB manipulations are best left to the Dev / Ops person. Don't automate it within the app.
tsagadar
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for local files with matching filenames but different hashes. This is done by moving the path of the files to
<artifact_dir>/<file_hash>/<filename>. Files with matching versions and compatibility will still collide and raise an error to the user.Fixes: #104